Skip to content

Make argname normalization robust and exit 1 if invalid arg #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
randallpittman wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make argname normalization robust and exit 1 if invalid arg #18

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2317394
Programmatically normalize all argnames from main() and exit 1 if inv…
Nov 2, 2023
10fdb71
exit 1 for invalid arg
Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 9 additions & 23 deletions sd_file_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,7 @@
# Implementation
#----------------
#
import inspect
import numpy
import os

Expand Down Expand Up @@ -1436,38 +1437,23 @@ def validCommandLineArgument( arg ):
if not (len(out) == 2):
#
print('ERROR: Unknown commandline argument: ' + arg)
sys.exit()
sys.exit(1)
#
key,val = out

if key.lower() in ['path']:
#
key = 'path'
#
elif key.lower() in ['outputfiletype']:
#
key = 'outputFileType'
#
elif key.lower() in ['spectra']:
#
key = 'spectra'
#
elif key.lower() in ['lffilter']:
#
key = 'lfFilter'
#
elif key.lower() in ['bulkparameters']:
#
key = 'bulkParameters'
#
# normalize arg names to the capitalization required by main()
argnames = list(inspect.signature(main).parameters)
for argname in argnames:
if key.lower() == argname.lower():
key = argname
break
else:
#
print('ERROR: unknown commandline argument ' + key)
sys.exit()
sys.exit(1)
#
return( key,val)
#

def getVersions( path ):
"""
This function retrieves sha from sys filenames; if no sha is present
Expand Down