docs(op-sqlite): use real executorch types in README usage example#20
Closed
msluszniak wants to merge 1 commit into
Closed
docs(op-sqlite): use real executorch types in README usage example#20msluszniak wants to merge 1 commit into
msluszniak wants to merge 1 commit into
Conversation
Swap the placeholder YourLLM / YourEmbeddings imports for the ExecuTorchLLM / ExecuTorchEmbeddings classes from @react-native-rag/executorch, wired up with the rne 0.9.0 models.* accessor. Mirrors the example shown in the root README and packages/executorch/README.md so the snippet is copy-pasteable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the placeholder `YourLLM` / `YourEmbeddings` imports in packages/op-sqlite/README.md with the actual `ExecuTorchLLM` / `ExecuTorchEmbeddings` classes from `@react-native-rag/executorch`, wired through the rne 0.9.0 `models.*` accessor. Mirrors the example already shown in the root README and `packages/executorch/README.md` so the snippet is copy-pasteable.
Why this is on a separate PR
`@react-native-rag/op-sqlite@0.9.0` failed to publish from the v0.9.0 tag due to a Sigstore/Rekor transparency-log conflict (the first publish attempt registered the tarball signature in Rekor before failing on the npm side, and Rekor refuses duplicate entries on retry). The other two packages published fine. This README touch changes the op-sqlite tarball bytes so Rekor will accept a fresh entry. Once merged, `v0.9.0` gets moved to the new commit and the workflow re-run for op-sqlite only.