fix(stop-metro): only kill the listener (keep execFileSync, no shell)#364
Draft
latekvo wants to merge 1 commit into
Draft
fix(stop-metro): only kill the listener (keep execFileSync, no shell)#364latekvo wants to merge 1 commit into
latekvo wants to merge 1 commit into
Conversation
…ed clients lsof -ti tcp:<port> returns every process with a socket on the port, including ESTABLISHED connections. The Argent tool-server holds a CDP client socket to Metro on that port, so stop-metro SIGTERM'd the tool-server along with Metro. Restrict the match with -sTCP:LISTEN so only the process listening on the port (Metro) is killed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
stop-metrorunslsof -ti tcp:<port>, which returns every process with a socket on the port — includingESTABLISHEDconnections, not just the listener. The Argent tool-server holds a CDP client socket to Metro on that port, sostop-metroSIGTERMs the tool-server along with Metro (it then auto-respawns, dropping in-memory profiler session state and disrupting any connected editor).Fix
Add
-sTCP:LISTENso only the process listening on the port (Metro) matches.This keeps the existing
execFileSync(no shell) call —portis never shell-interpreted, preserving the defense-in-depth in the original code.Verification
Listener-vs-client repro:
lsof -ti tcp:<port>returns both the listener and a connected client pid;lsof -ti tcp:<port> -sTCP:LISTENreturns only the listener.