ci: device E2E smoke tests for every hosted-CI platform#371
Draft
latekvo wants to merge 2 commits into
Draft
Conversation
05126ff to
2296695
Compare
Extends the Android-on-Linux coverage in wayland-e2e.yml to the rest of the supported (target x host) matrix that can run on GitHub-hosted runners: - iOS simulator on macOS - Chromium/Electron on Linux (Xvfb) - Chromium/Electron on macOS Each job boots one device through the tool-server and asserts the headless interaction pipeline via a shared scripts/e2e/drive-device.sh: booted:true -> screenshot returns real pixels -> gesture-tap round-trips. The Chromium cells point at a minimal self-contained Electron fixture that vendors its own electron (kept out of the root lockfile). Documented as known gaps (supported on real machines, not runnable on hosted runners): Android emulator on macOS (the arm64 emulator needs HVF, but hosted macOS runners are VMs with no nested virtualization -> HV_UNSUPPORTED; the Android path is already guarded on Linux via KVM), and physical iOS/Android devices (no attached hardware).
2296695 to
bf27031
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
wayland-e2e.ymlboots an Android AVD on Linux under headless Weston and asserts the full pipeline works without a display. It guards exactly one cell of the support matrix. This adds the same boot→screenshot→gesture-tap smoke test for every other (target × host) cell that can run on GitHub-hosted runners.wayland-e2e.yml(existing)ios-sim-macoschromium-linuxchromium-macosHow
scripts/e2e/drive-device.sh— shared driver. Boots one device through the tool-server, then assertsbooted:true→ screenshot has real (non-blank) pixels →gesture-tapround-trips. Every tool takes the device id asudidand screenshots come back as the samedata.image.hostPathenvelope on all platforms, so the body is uniform; each job just supplies the cell-specific boot JSON + device id.packages/tool-server/test/fixtures/electron-smoke-app/— minimal self-contained Electron app the Chromium jobs pointelectronAppPathat. It vendors its own electron via its own lockfile (kept out of the repo root lockfile); CInpm cis it soboot-electronresolves./node_modules/.bin/electron..github/workflows/e2e-device-smoke.yml— three jobs,workflow_dispatch+ path-filteredpull_request. iOS downloads the darwin native binaries (injection must succeed forbootIosto reportbooted:true); Chromium-Linux runs under Xvfb with--no-sandbox. The tool-server is started withTS_NODE_TRANSPILE_ONLY=1so cold ts-node startup doesn't flakily exceed the readiness poll on loaded macOS runners (types are still enforced by the typecheck job).Known gaps (supported on real machines, not runnable on hosted runners)
-enable-hvf), but hosted macOS runners are themselves VMs with no nested virtualization. Confirmed by running it: qemu dies withHVF error: HV_UNSUPPORTED~18s into boot, regardless of GPU mode or RAM. The Android boot/screenshot/tap path is already regression-guarded on Linux via KVM (wayland-e2e.yml), so macOS adds no runnable coverage.Both would need self-hosted runners (a Mac exposing HVF / wired-up devices). Documented in the workflow header.
Verification
drive-device.shend-to-end against a real tool-server → bootbooted:true, screenshot 142 KB (floor 20 KB), taptapped:true, exit 0; and confirmed via the Argent stack that a tap at (0.5, 0.5) lands on the fixture's centered button and increments its counter.