[LLV] Kanban demo#634
Conversation
| return; | ||
| } | ||
| view.update(diff, []); | ||
| // The diff is delivered from the Popcorn WASM iframe via run_js, so its |
There was a problem hiding this comment.
Isn't the 'realm problem' a problem for every time when we want to deliver an array over a popcorns run_js?
Shouldn't the solution be handled on the "realm-border" as a part of popcorn functionality?
| end | ||
| end | ||
|
|
||
| defp component_handle_event_call(_component_socket, _component, "lv:" <> _ = bad_event, _val) do |
There was a problem hiding this comment.
This seems similar to view_handle_event function - maybe we can refactor this to DRY up the code.
| end | ||
| end | ||
|
|
||
| defp component_handle_event_call(component_socket, _component, "lv:clear-flash", val) do |
There was a problem hiding this comment.
This seems similar to view_handle_event function - maybe we can refactor this to DRY up the code.
| @spec start_link([option]) :: GenServer.on_start() | ||
| def start_link(opts \\ []) do | ||
| opts = Keyword.validate!(opts, dirs: [Path.absname("local")]) | ||
| opts = Keyword.validate!(opts, dirs: [Path.absname("local/lib")]) |
There was a problem hiding this comment.
What is the purpose of this change?
Also we need to keep in mind this will influence other examples.
| <div | ||
| phx-dragover="drag_over_column" | ||
| phx-value-column_id={@col.id} | ||
| style={"flex:0 0 280px;background:#1f2937;border:1px solid #{if @dragging, do: "#4b6bb3", else: "#374151"};border-radius:8px;padding:0.75em;display:flex;flex-direction:column;gap:0.6em"} |
There was a problem hiding this comment.
For me inline-style'ing is suboptimal when it comes to readability.
2 participants
Demo showcasing simple forms, modals, and drag&drop with LLV. Server sync will come in another PR.
Other changes:
phx-targetfor live components - again, not sure if this is how it should be donemaps:takereturn value - found accidentally, didn't break anything so far AFAIK