fix(iOS): image y positioning#656
Open
kacperzolkiewski wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses an iOS-specific issue where inline attachment image overlays (e.g., inserted images/GIFs) could “jump” vertically when text is inserted/removed around them, by repositioning attachment views only after a forced full text layout pass has completed.
Changes:
- Removed the immediate
layoutAttachmentscall fromanyTextMayHaveBeenModified. - Added
layoutAttachmentsto run at the end of_performRelayout, after layout invalidation/ensure-layout andcontentSizerecomputation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes image y positioning
Test Plan
Screenshots / Videos
Before:
Screen.Recording.2026-06-22.at.12.10.44.mov
After:
Screen.Recording.2026-06-24.at.16.53.12.mov
Compatibility
Checklist