Skip to content

chore: rename example app directory to react-native-example #414

Merged
hryhoriiK97 merged 3 commits into
mainfrom
graszka22/rename-example-app
Jun 19, 2026
Merged

chore: rename example app directory to react-native-example #414
hryhoriiK97 merged 3 commits into
mainfrom
graszka22/rename-example-app

Conversation

@graszka22

@graszka22 graszka22 commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

What/Why?

Rename example app directory to react-native-example.
The first commit is just directory rename, the second are scripts updates etc.

Testing

Run the example apps.

PR Checklist

  • Code compiles and runs on iOS
  • Code compiles and runs on Android
  • Updated documentation/README if applicable
  • Ran example app to verify changes
  • E2E tests are passing
  • Required E2E tests have been added (if applicable)

Base automatically changed from graszka22/android-example-app to main June 19, 2026 13:44
graszka22 and others added 2 commits June 19, 2026 15:48
Move apps/example to apps/react-native-example without content changes.

Co-authored-by: Cursor <cursoragent@cursor.com>
@graszka22 graszka22 force-pushed the graszka22/rename-example-app branch from 067cf83 to bd04d4a Compare June 19, 2026 13:50
@graszka22 graszka22 marked this pull request as ready for review June 19, 2026 14:13
@graszka22 graszka22 requested a review from hryhoriiK97 June 19, 2026 14:13

@hryhoriiK97 hryhoriiK97 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I've left only one comment - please take a look at it 🙏

Comment thread .github/workflows/ci.yml
TURBO_CACHE_STATUS=$(yarn turbo run build:ios \
--filter=react-native-enriched-markdown-example \
--filter=react-native-example \
--cache-dir="${{ env.TURBO_CACHE_DIR }}" \

@hryhoriiK97 hryhoriiK97 Jun 19, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The turbo filter was changed to --filter=react-native-example, but the package name in apps/react-native-example/package.json is still react-native-enriched-markdown-example (the file was renamed without content changes). Turbo matches by package name, so this filter won't find the workspace.

Should either keep --filter=react-native-enriched-markdown-example or also rename the package in package.json.

@hryhoriiK97 hryhoriiK97 merged commit 7f15e16 into main Jun 19, 2026
4 checks passed
@hryhoriiK97 hryhoriiK97 deleted the graszka22/rename-example-app branch June 19, 2026 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants