feat: Run border width and radius CSS transitions on Core Animation#9657
Closed
MatiPl01 wants to merge 1 commit into
Closed
feat: Run border width and radius CSS transitions on Core Animation#9657MatiPl01 wants to merge 1 commit into
MatiPl01 wants to merge 1 commit into
Conversation
d418cd8 to
9118a15
Compare
715ceb7 to
5d4c848
Compare
9118a15 to
3c385cc
Compare
5d4c848 to
2884c02
Compare
3c385cc to
5a1dcdf
Compare
12b2e39 to
7ead0ff
Compare
99e1180 to
d25095a
Compare
1aaf3db to
d1f0069
Compare
d25095a to
830492b
Compare
d1f0069 to
d5f7d4e
Compare
5cb1782 to
11e3081
Compare
d5f7d4e to
4a73f19
Compare
11e3081 to
eab37fc
Compare
1afff13 to
dfc3207
Compare
a68b970 to
5f80493
Compare
3f5f3d8 to
1de54e0
Compare
5f80493 to
41bcf18
Compare
1de54e0 to
7a546f0
Compare
41bcf18 to
c779dae
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #9656.
Adds
borderWidthandborderRadiusto the platform-routed CSS transition properties (behindIOS_CSS_CORE_ANIMATION).borderRadiusmaps to CALayer'scornerRadiuskeypath (apply and remove paths).Both properties route only while RN uses Core Animation border rendering for the view; views drawn through RN's rasterized border path keep transitioning on the loop, which redraws the border every frame.
Test plan
-fsyntax-onlycompile check, clang-format cleanIOS_CSS_CORE_ANIMATIONflag enabled