MPT-19486 unskip attachment e2e tests

[jentyk]

Closes MPT-19486

• Unskip three async attachment e2e tests in test_async_attachment.py: test_get_chat_attachment_not_found, test_update_chat_attachment_not_found, and test_delete_chat_attachment_not_found
• Unskip three sync attachment e2e tests in test_sync_attachment.py: test_get_chat_attachment_not_found, test_update_chat_attachment_not_found, and test_delete_chat_attachment_not_found
• These tests now execute and validate that the corresponding ChatAttachmentsService methods raise MPTAPIError with HTTPStatus.NOT_FOUND status

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 6b9d0ff1-86d7-4ed5-a9c0-3a12cc9aef4b

📥 Commits

Reviewing files that changed from the base of the PR and between 9ef1497 and bf8bf21.

📒 Files selected for processing (2)

• tests/e2e/helpdesk/chats/attachment/test_async_attachment.py
• tests/e2e/helpdesk/chats/attachment/test_sync_attachment.py

💤 Files with no reviewable changes (2)

• tests/e2e/helpdesk/chats/attachment/test_sync_attachment.py
• tests/e2e/helpdesk/chats/attachment/test_async_attachment.py

---

📝 Walkthrough

Walkthrough

The pull request removes @pytest.mark.skip decorators from six e2e test functions across two test files, enabling these previously skipped tests to execute. The tests continue to assert that specific ChatAttachmentsService methods raise MPTAPIError with HTTPStatus.NOT_FOUND status.

Changes

Cohort / File(s)	Summary
Chat Attachments E2E Tests tests/e2e/helpdesk/chats/attachment/test_async_attachment.py, tests/e2e/helpdesk/chats/attachment/test_sync_attachment.py	Removed @pytest.mark.skip(reason="Unskip after MPT-19124 completed") decorators from three test functions in each file (test_get_chat_attachment_not_found, test_update_chat_attachment_not_found, test_delete_chat_attachment_not_found). Test assertions remain unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

• MPT-19124 mark chat tests as skipped pending MPT-19124 completion #240 — Previously added the skip decorators to the same three test functions that are now being unskipped.
• MPT-18971 introduce chat attachments module with sync and async support #236 — Related PR that also unskips e2e attachment tests as part of addressing the MPT-19124 ticket.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Jira Issue Key In Title	✅ Passed	The PR title contains exactly one valid Jira issue key (MPT-19486) in the correct format.
Test Coverage Required	✅ Passed	The pull request modifies only test files in the tests/ folder, removing skip decorators. No code files outside the tests/ folder are modified.
Single Commit Required	✅ Passed	The pull request contains exactly one commit that removes pytest skip decorators from attachment e2e tests.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud