Skip to content

MPT-19487 unskip chat messages e2e tests#257

Merged
d3rky merged 1 commit intomainfrom
feat/MPT-19487
Mar 30, 2026
Merged

MPT-19487 unskip chat messages e2e tests#257
d3rky merged 1 commit intomainfrom
feat/MPT-19487

Conversation

@jentyk
Copy link
Copy Markdown
Member

@jentyk jentyk commented Mar 30, 2026

Closes MPT-19487

  • Unskipped test_list_chat_messages end-to-end test in tests/e2e/helpdesk/chats/messages/test_async_messages.py
  • Unskipped test_list_chat_messages end-to-end test in tests/e2e/helpdesk/chats/messages/test_sync_messages.py

@jentyk jentyk requested a review from a team as a code owner March 30, 2026 08:20
@jentyk jentyk requested review from d3rky and svazquezco March 30, 2026 08:20
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 30, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 0d48bc51-962c-4e47-8528-c726882122eb

📥 Commits

Reviewing files that changed from the base of the PR and between 9ef1497 and 314ba5b.

📒 Files selected for processing (2)
  • tests/e2e/helpdesk/chats/messages/test_async_messages.py
  • tests/e2e/helpdesk/chats/messages/test_sync_messages.py
💤 Files with no reviewable changes (2)
  • tests/e2e/helpdesk/chats/messages/test_async_messages.py
  • tests/e2e/helpdesk/chats/messages/test_sync_messages.py

📝 Walkthrough

Walkthrough

This pull request removes the @pytest.mark.skip decorators from test_list_chat_messages in two end-to-end test files for helpdesk chat messaging. Previously skipped pending completion of task MPT-19124, these tests are now enabled to run.

Changes

Cohort / File(s) Summary
Test Skip Removal
tests/e2e/helpdesk/chats/messages/test_async_messages.py, tests/e2e/helpdesk/chats/messages/test_sync_messages.py
Removed @pytest.mark.skip(reason="Unskip after MPT-19124 completed") decorator from test_list_chat_messages in both async and sync message test files, enabling these E2E tests to execute.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Jira Issue Key In Title ✅ Passed The PR title contains exactly one Jira issue key (MPT-19487) in the required MPT-XXXX format.
Test Coverage Required ✅ Passed PR only modifies test files in tests/ directory with no code file modifications, so the requirement to include tests when modifying code is not applicable.
Single Commit Required ✅ Passed The PR contains exactly one commit (314ba5b: "test(helpdesk): unskip chat messages e2e tests") that removes @pytest.mark.skip decorators from helpdesk test files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

@d3rky d3rky merged commit d64eb8e into main Mar 30, 2026
4 checks passed
@d3rky d3rky deleted the feat/MPT-19487 branch March 30, 2026 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants