Skip to content

MPT-19489 unskip some chat participants e2e tests #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jentyk merged 1 commit into from
Mar 30, 2026
Merged

MPT-19489 unskip some chat participants e2e tests #258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions tests/e2e/helpdesk/chats/participants/test_async_participants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
pytestmark = [pytest.mark.flaky]


@pytest.mark.skip(reason="Unskip after MPT-19124 completed")
async def test_list_chat_participants(async_chat_participants_service):
result = await async_chat_participants_service.fetch_page(limit=1)

Expand Down Expand Up @@ -42,7 +41,6 @@ async def test_delete_chat_participant(
await async_chat_participants_service.delete(result.id)


@pytest.mark.skip(reason="Unskip after MPT-19124 completed")
async def test_update_chat_participant_not_found(
async_chat_participants_service, invalid_chat_participant_id
):
Expand All @@ -54,10 +52,9 @@ async def test_update_chat_participant_not_found(
assert error.value.status_code == HTTPStatus.NOT_FOUND


@pytest.mark.skip(reason="Unskip after MPT-19124 completed")
async def test_delete_chat_participant_not_found(
async_chat_participants_service, invalid_chat_participant_id
):
with pytest.raises(MPTAPIError) as error:
await async_chat_participants_service.delete(invalid_chat_participant_id)
assert error.value.status_code == HTTPStatus.NOT_FOUND
assert error.value.status_code == HTTPStatus.BAD_REQUEST # TODO: verify 400 is OK instead 404
5 changes: 1 addition & 4 deletions tests/e2e/helpdesk/chats/participants/test_sync_participants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
pytestmark = [pytest.mark.flaky]


@pytest.mark.skip(reason="Unskip after MPT-19124 completed")
def test_list_chat_participants(chat_participants_service):
result = chat_participants_service.fetch_page(limit=1)

Expand All @@ -35,17 +34,15 @@ def test_delete_chat_participant(chat_participants_service, created_chat_partici
chat_participants_service.delete(result.id)


@pytest.mark.skip(reason="Unskip after MPT-19124 completed")
def test_update_chat_participant_not_found(chat_participants_service, invalid_chat_participant_id):
with pytest.raises(MPTAPIError) as error:
chat_participants_service.update(invalid_chat_participant_id, {"status": "Active"})

assert error.value.status_code == HTTPStatus.NOT_FOUND


@pytest.mark.skip(reason="Unskip after MPT-19124 completed")
def test_delete_chat_participant_not_found(chat_participants_service, invalid_chat_participant_id):
with pytest.raises(MPTAPIError) as error:
chat_participants_service.delete(invalid_chat_participant_id)

assert error.value.status_code == HTTPStatus.NOT_FOUND
assert error.value.status_code == HTTPStatus.BAD_REQUEST # TODO: verify 400 is OK instead 404
Loading