Skip to content

MPT-19488 unskip async and sync chat link not found tests#259

Merged
d3rky merged 1 commit intomainfrom
feat/MPT-19488
Mar 30, 2026
Merged

MPT-19488 unskip async and sync chat link not found tests#259
d3rky merged 1 commit intomainfrom
feat/MPT-19488

Conversation

@jentyk
Copy link
Copy Markdown
Member

@jentyk jentyk commented Mar 30, 2026

Closes MPT-19488

Changes

  • Unskipped test_update_chat_link_not_found and test_delete_chat_link_not_found tests in the async chat links E2E test suite
  • Unskipped test_update_chat_link_not_found and test_delete_chat_link_not_found tests in the sync chat links E2E test suite
  • These tests now execute and validate that updating or deleting a chat link with an invalid ID raises MPTAPIError with HTTPStatus.NOT_FOUND

@jentyk jentyk requested a review from a team as a code owner March 30, 2026 08:25
@jentyk jentyk requested review from albertsola and robcsegal March 30, 2026 08:25
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 30, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 2e3c93f2-7a86-4ef9-9145-c39c3a391632

📥 Commits

Reviewing files that changed from the base of the PR and between 9ef1497 and bd3a775.

📒 Files selected for processing (2)
  • tests/e2e/helpdesk/chats/links/test_async_links.py
  • tests/e2e/helpdesk/chats/links/test_sync_links.py
💤 Files with no reviewable changes (2)
  • tests/e2e/helpdesk/chats/links/test_async_links.py
  • tests/e2e/helpdesk/chats/links/test_sync_links.py

📝 Walkthrough

Walkthrough

Two E2E test files had @pytest.mark.skip decorators removed from identical test functions (test_update_chat_link_not_found and test_delete_chat_link_not_found), enabling these previously skipped tests to execute without changes to their test logic or assertions.

Changes

Cohort / File(s) Summary
Skipped tests enabled
tests/e2e/helpdesk/chats/links/test_async_links.py, tests/e2e/helpdesk/chats/links/test_sync_links.py
Removed @pytest.mark.skip decorators from test_update_chat_link_not_found and test_delete_chat_link_not_found, enabling these tests to execute and validate MPTAPIError exceptions for invalid chat link operations.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • PR #240: Modifies pytest skip decorators on the same test functions in both test_async_links.py and test_sync_links.py.
  • PR #237: Modifies the same chat-links end-to-end tests for update/delete-not-found scenarios.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Jira Issue Key In Title ✅ Passed The PR title contains exactly one Jira issue key (MPT-19488) in the correct MPT-XXXX format at the beginning, with no duplicates.
Test Coverage Required ✅ Passed PR modifies only test files in tests/ folder with no production code changes, satisfying the passed condition.
Single Commit Required ✅ Passed The PR contains exactly one commit (bd3a775 test(helpdesk): unskip async and sync chat link not found tests), which satisfies the single commit requirement.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

@d3rky d3rky merged commit 4635cda into main Mar 30, 2026
4 checks passed
@d3rky d3rky deleted the feat/MPT-19488 branch March 30, 2026 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants