MPT-19124 remove session scope from pdf_fd and logo_fd fixtures

[jentyk]

Closes MPT-19124

• Removed session scope from pdf_fd and logo_fd fixtures so they are function-scoped (no longer shared across the test session)
• Ensured both fixtures use context-managed yield for file handles (fixture-managed cleanup of opened files)

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: c29c84c3-fa31-4cd9-9d83-61966e0493f7

📥 Commits

Reviewing files that changed from the base of the PR and between de1a71f and 8ee5980.

📒 Files selected for processing (1)

• tests/e2e/conftest.py

🚧 Files skipped from review as they are similar to previous changes (1)

• tests/e2e/conftest.py

---

📝 Walkthrough

Walkthrough

Two pytest fixtures in tests/e2e/conftest.py were changed from session scope to default (function) scope. logo_fd was also refactored to open the file with a context manager and yield the handle to ensure the file is closed at teardown; pdf_fd scope only changed.

Changes

Cohort / File(s)	Summary
Test fixtures tests/e2e/conftest.py	Removed scope="session" from pdf_fd and logo_fd fixtures (now function-scoped). logo_fd now opens the file with a context manager and yields the file handle instead of returning an open file object; pdf_fd retains context/yield behavior but scope changed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Jira Issue Key In Title	✅ Passed	The PR title contains exactly one valid Jira issue key (MPT-19124) in the correct format at the beginning.
Test Coverage Required	✅ Passed	PR modifies only test fixture definitions in tests/e2e/conftest.py with no source code modifications.
Single Commit Required	✅ Passed	The PR contains exactly one commit (8ee5980 fix(e2e): remove session scope from pdf_fd and logo_fd fixtures), which meets the requirement.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud