Skip to content

MPT-19124 remove module scope from fixtures#265

Merged
jentyk merged 1 commit intomainfrom
feat/MPT-19124
Mar 30, 2026
Merged

MPT-19124 remove module scope from fixtures#265
jentyk merged 1 commit intomainfrom
feat/MPT-19124

Conversation

@jentyk
Copy link
Copy Markdown
Member

@jentyk jentyk commented Mar 30, 2026

Closes MPT-19124

  • Changed e2e pytest fixtures to use function scope instead of module scope
    • Affected fixtures: mpt_vendor, async_mpt_vendor, mpt_ops, async_mpt_ops, mpt_client, and async_mpt_client
    • Each test function now receives a fresh instance of these fixtures instead of sharing a single instance across the entire test module
    • Client configuration logic via MPTClient.from_config and AsyncMPTClient.from_config remains unchanged

@jentyk jentyk requested a review from a team as a code owner March 30, 2026 18:55
@jentyk jentyk requested review from robcsegal and svazquezco March 30, 2026 18:55
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 30, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: ea727103-7d77-4214-8cd1-42a7d270b31f

📥 Commits

Reviewing files that changed from the base of the PR and between 7bd1fff and 43d6bfd.

📒 Files selected for processing (1)
  • tests/e2e/conftest.py

📝 Walkthrough

Walkthrough

Six pytest fixtures in the end-to-end test configuration had their scope changed from module-level to function-level (default). The internal client construction logic remains unchanged; only fixture setup and teardown frequency is affected.

Changes

Cohort / File(s) Summary
E2E Fixture Scope Adjustment
tests/e2e/conftest.py
Six fixtures (mpt_vendor, async_mpt_vendor, mpt_ops, async_mpt_ops, mpt_client, async_mpt_client) changed from module scope to function scope by removing the scope="module" decorator parameter.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Jira Issue Key In Title ✅ Passed The PR title contains exactly one Jira issue key MPT-19124 in the correct MPT-XXXX format.
Test Coverage Required ✅ Passed PR modifies only test file (tests/e2e/conftest.py) with no production code changes in mpt_api_client/
Single Commit Required ✅ Passed The PR contains exactly one commit (43d6bfd: fix(e2e): remove module scope from fixtures) as verified by comparing the current branch against the main branch, meeting the requirement for a single commit and keeping git history clean.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

@jentyk jentyk merged commit 3cdd0d1 into main Mar 30, 2026
4 checks passed
@jentyk jentyk deleted the feat/MPT-19124 branch March 30, 2026 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants