Add large-data timeout and API wait helpers#389
Merged
SteveChurchillSWO merged 1 commit intomainfrom Mar 27, 2026
Merged
Conversation
Introduce LARGE_DATA_TIMEOUT and replace fragile canvas waits with network-based waits to better handle slow/large data loads. Key changes: - e2etests/playwright.config.ts: add LARGE_DATA_TIMEOUT (30000ms) for long-running operations. - e2etests/pages/base-page.ts: use LARGE_DATA_TIMEOUT as default for several waits, add noDataMessage locator, implement waitForAPIResponseByPartialTextMatch and waitForFirstAPIResponseByPartialTextMatch helpers, refine waitForAllCanvases signature, and harden selectFilter option matching (escape + regex). - e2etests/pages/resources-page.ts: import LARGE_DATA_TIMEOUT and switch tab/navigation/chart waits to rely on the new API wait helpers (and progress-bar waits) instead of canvas checks; make several methods accept optional wait flags or timeouts; minor locator robustness improvements. - e2etests/tests/*.spec.ts: update tests to use the new navigateToResourcesPageAndResetFilters and to call selectCategorizeBy without implicit waits where appropriate, adding explicit API/canvas waits where needed. These updates improve reliability on slow CI or when pages load large datasets by waiting for specific API responses rather than relying solely on canvas rendering heuristics.
dwolosz
approved these changes
Mar 27, 2026
SteveChurchillSWO
deleted the
MPT-19651-Improve-wait-for-large-data-volumes
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduce LARGE_DATA_TIMEOUT and replace fragile canvas waits with network-based waits to better handle slow/large data loads. Key changes:
These updates improve reliability on slow CI or when pages load large datasets by waiting for specific API responses rather than relying solely on canvas rendering heuristics.
Related issue number
https://softwareone.atlassian.net/browse/MPT-19651