Skip to content

Use cryptohash-sha256, not crypton, for SHA256 hashes #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mpilgrem wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −9
Open

Use cryptohash-sha256, not crypton, for SHA256 hashes #640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
## Changes in 0.39.2
- Depend on `cryptohash-sha256`, rather than `crypton`, for SHA256 hashes

## Changes in 0.39.1
- Add support for `mhs-options` (MicroHs)

Expand Down
10 changes: 5 additions & 5 deletions hpack.cabal
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
spec-version: 0.36.0
name: hpack
version: 0.39.1
version: 0.39.2
synopsis: A modern format for Haskell packages
description: See README at <https://github.com/sol/hpack#readme>
author: Simon Hengel <sol@typeful.net>
Expand All @@ -16,6 +16,7 @@ ghc-options: -Wall -fno-warn-incomplete-uni-patterns
dependencies:
- base >= 4.13 && < 5
- bytestring
- cryptohash-sha256
- deepseq
- directory >= 1.2.5.0
- filepath
Expand All @@ -29,7 +30,6 @@ dependencies:
- Cabal >= 3.0.0.0 && < 3.17
- pretty
- bifunctors
- crypton
- transformers
- mtl
- http-types
Expand Down
4 changes: 2 additions & 2 deletions src/Hpack/Util.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ import System.Directory
import System.FilePath
import qualified System.FilePath.Posix as Posix
import System.FilePath.Glob
import Crypto.Hash
import qualified Crypto.Hash.SHA256 as SHA256

import Hpack.Haskell
import Hpack.Utf8 as Utf8
Expand Down Expand Up @@ -130,7 +130,7 @@ expandGlobs name dir patterns = do
type Hash = String

sha256 :: String -> Hash
sha256 c = show (hash (Utf8.encodeUtf8 c) :: Digest SHA256)
sha256 c = show (SHA256.hash (Utf8.encodeUtf8 c))

nub :: Ord a => [a] -> [a]
nub = nubOn id
Expand Down