Skip to content

PUT or PATCH on auxiliary resources #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kjetilk wants to merge 51 commits into
base: main
Choose a base branch
from
Draft

PUT or PATCH on auxiliary resources #65

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
0828dc8
Add Allow header tests
kjetilk Dec 24, 2021
da22cc2
Add Allow header tests
kjetilk Dec 24, 2021
c42f209
Use And keyword
kjetilk Dec 27, 2021
fc235ee
Test for POST to non-existing
kjetilk Dec 28, 2021
122093b
First stab at describedby aux resource
kjetilk Dec 28, 2021
5135713
Add content-type
kjetilk Dec 28, 2021
7e1f551
RDF refers to resource
kjetilk Dec 28, 2021
eb11061
Make comparison case-insensitive
kjetilk Dec 29, 2021
c53affa
Add more content-types
kjetilk Dec 29, 2021
b3aa723
First test for deleting containment triple
kjetilk Dec 30, 2021
6438952
Move test resource creation
kjetilk Dec 30, 2021
6d76af0
Add container removal
kjetilk Dec 30, 2021
32bc72f
Add test for text resource
kjetilk Dec 30, 2021
b650f2f
First test for protected container
kjetilk Dec 30, 2021
d9c1dac
Tests for other resources
kjetilk Dec 30, 2021
5fad293
Update protocol/solid-protocol-test-manifest.ttl
kjetilk Jan 7, 2022
7663498
Update protocol/solid-protocol-test-manifest.ttl
kjetilk Jan 7, 2022
3e43192
Update protocol/solid-protocol-test-manifest.ttl
kjetilk Jan 7, 2022
f7712ff
Update protocol/read-write-resource/read-method-allow.feature
kjetilk Jan 7, 2022
a3ed941
Update protocol/read-write-resource/read-method-allow.feature
kjetilk Jan 7, 2022
6f1282e
Update protocol/solid-protocol-test-manifest.ttl
kjetilk Jan 7, 2022
3127b7a
Update protocol/writing-resource/delete-protect-nonempty-container.fe…
kjetilk Jan 7, 2022
b53202b
Update protocol/writing-resource/delete-protect-nonempty-container.fe…
kjetilk Jan 7, 2022
0f86cc8
Update protocol/writing-resource/delete-protect-nonempty-container.fe…
kjetilk Jan 7, 2022
f5d5af1
Merge pull request #67 from solid/feature/after-resource-deletion
kjetilk Jan 7, 2022
094ab59
Update protocol/solid-protocol-test-manifest.ttl
kjetilk Jan 7, 2022
cd678c5
Merge branch 'main' into proposal/post-target-not-found
kjetilk Jan 7, 2022
38b231c
Merge branch 'main' into feature/read-method-allow
kjetilk Jan 7, 2022
747e156
Merge branch 'main' into feature/delete-protect-nonempty-container
kjetilk Jan 7, 2022
6ef293b
Merge pull request #68 from solid/feature/delete-protect-nonempty-con…
kjetilk Jan 7, 2022
b523083
Merge branch 'main' into feature/read-method-allow
kjetilk Jan 7, 2022
c4f35ee
Merge pull request #63 from solid/feature/read-method-allow
kjetilk Jan 7, 2022
c8bbe65
Be explicit about allowed rather than the vague and non-exciting term…
kjetilk Jan 7, 2022
87dd379
Test for POST to non-existing
kjetilk Dec 28, 2021
765326c
Add more content-types
kjetilk Dec 29, 2021
b0f8506
Make the GET test part of previous test
kjetilk Jan 8, 2022
1a99ae4
Initialize resources in scenarios
kjetilk Jan 8, 2022
c04107f
Check with GET for all resources
kjetilk Jan 8, 2022
08431c5
Send bodies with all POSTs
kjetilk Jan 8, 2022
5c8aa61
Resolve conflicts (I hope...)
kjetilk Jan 8, 2022
cea8290
Update protocol/writing-resource/delete-protect-nonempty-container.fe…
kjetilk Jan 10, 2022
d44f2cc
Merge pull request #64 from solid/proposal/post-target-not-found
kjetilk Jan 10, 2022
dba4f0d
First stab at describedby aux resource
kjetilk Dec 28, 2021
49ea325
Add content-type
kjetilk Dec 28, 2021
44219a9
RDF refers to resource
kjetilk Dec 28, 2021
009f613
Make comparison case-insensitive
kjetilk Dec 29, 2021
61b518b
Update protocol/solid-protocol-test-manifest.ttl
kjetilk Jan 7, 2022
297dbaf
Add tests for more creates
kjetilk Jan 13, 2022
a2a1ff6
Add test for updates
kjetilk Jan 13, 2022
1a36a38
Minor
kjetilk Jan 13, 2022
35e6a0e
Merge changes
kjetilk Jan 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions protocol/solid-protocol-test-manifest.ttl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,3 +96,10 @@ manifest:slug-uri-assignment
spec:testScript
<https://github.com/solid/specification-tests/protocol/read-write-resource/post-uri-assignment-slug.feature> .

manifest:put-patch-auxiliary-resource
a td:TestCase ;
spec:requirementReference sopr:server-put-patch-auxiliary-resource ;
td:reviewStatus td:unreviewed ;
spec:testScript
<https://github.com/solid/specification-tests/protocol/writing-resource/put-patch-auxiliary-resource.feature> .

19 changes: 19 additions & 0 deletions protocol/writing-resource/put-patch-auxiliary-resource.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
Feature: PUT or PATCH on auxiliary resources

Background: Set up container and parse link headers
* def testContainer = rootTestContainer.createContainer()
* def container = testContainer.createContainer()
* def exampleTurtle = karate.readAsString('../fixtures/example.ttl')
* def rdfResource = testContainer.createResource('.ttl', exampleTurtle, 'text/turtle');

Scenario: PUT auxiliary resource to container
* def response = clients.alice.sendAuthorized('GET', container.url, null, null)
* def links = parseLinkHeaders(response.headers)
Comment on lines +11 to +12
Copy link
Collaborator

@edwardsph edwardsph Jan 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* def response = clients.alice.sendAuthorized('GET', container.url, null, null)
* def links = parseLinkHeaders(response.headers)
Given url container.url
And headers clients.alice.getAuthHeaders('GET', container.url)
When method GET
* def links = parseLinkHeaders(responseHeaders)

Why not use the normal GET? I know it is longer but I see no need for the special case of sendAuthorized()

Copy link
Collaborator Author

@kjetilk kjetilk Jan 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did that because I don't think of that as a test in its own right, that's just there to get the link. No strong opinions though.

Copy link
Collaborator

@edwardsph edwardsph Jan 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense to me and I have done similar elsewhere (e.g. every time we create a test container or resource). In this case, I wonder if we should provide overrides to the sendAuthorized method so that there are simpler variants making the test easier to read. Let's discuss.

* def describedby = links.find(el => el.rel.toLowerCase() === 'describedby')
* def metaUrl = resolveUri(container.url, describedby.uri)
Given url metaUrl
And headers clients.alice.getAuthHeaders('PUT', metaUrl)
And header Content-Type = 'text/turtle'
And request "<./> a <#Something> ."
When method PUT
Then status 201