fix: repeat must not mutate its result object in place (#785)

[webstrand]

Fixes #785

This substantially rewrites repeat to be more straight-forward with fewer closures, unlike #786 which is more conservative.

[changeset-bot]

🦋 Changeset detected

Latest commit: 0192f34

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@solid-primitives/range	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[webstrand]

This is actually kind of broken still, if the array returned from repeat()() is mutated, internal state can be corrupted

[thetarnav]

That’s fine
The same probably happens with mapArray and others
When mutating the result one should copy
Nothing broken with that

[webstrand]

Is it appropriate to narrow the return type to readonly T[] then to signal to users not to mutate the return value?

I've narrowed the return type in the most recent batch of commits, and I've fixed a bug in my implementation and added another test.

I'm not sure if you'd rather have a single commit in the PR or multiple?

[thetarnav]

readonly arrays are not allowed by JSX types, so I wouldn't do that.

[webstrand]

Ah is it intended then that repeat() be typed for being passed into JSX directly? The <Repeat> wrapper doesn't have any trouble with it, since it casts to JSX.Element directly ignoring the readonly annotation.