Skip to content

Correct jsdoc for ParentProps and ParentComponent #2480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryansolid merged 1 commit into from
May 16, 2025
+2 −2
Merged

Correct jsdoc for ParentProps and ParentComponent #2480

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/solid/src/render/component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,13 @@ export type VoidComponent<P extends Record<string, any> = {}> = Component<VoidPr

/**
* Extend props to allow an optional `children` prop with the usual
* type in JSX, `JSX.Element` (which allows elements, arrays, functions, etc.).
* type in JSX, `JSX.Element` (which allows elements, arrays, strings, etc.).
* Use this for components that you want to accept children.
*/
export type ParentProps<P extends Record<string, any> = {}> = P & { children?: JSX.Element };
/**
* `ParentComponent` allows an optional `children` prop with the usual
* type in JSX, `JSX.Element` (which allows elements, arrays, functions, etc.).
* type in JSX, `JSX.Element` (which allows elements, arrays, strings, etc.).
* Use this for components that you want to accept children.
*/
export type ParentComponent<P extends Record<string, any> = {}> = Component<ParentProps<P>>;
Expand Down
Loading