Skip to content

Avoid an N+1 loading stock on the admin products index #6495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ikraamg wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −1
Open

Avoid an N+1 loading stock on the admin products index #6495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion admin/app/controllers/solidus_admin/products_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ def index
Spree::Product.includes(
:variant_images,
master: :prices,
variants: :prices
variants: :prices,
variants_including_master: {stock_items: :stock_location}
),
param: :q,
distinct: false
Expand Down
14 changes: 14 additions & 0 deletions admin/spec/requests/solidus_admin/products_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,20 @@
allow_any_instance_of(SolidusAdmin::BaseController).to receive(:spree_current_user).and_return(admin_user)
end

describe "GET #index" do
Comment thread
tvdeyen marked this conversation as resolved.
before { create_list(:product, 3) }

it "renders successfully" do
Comment thread
tvdeyen marked this conversation as resolved.
get solidus_admin.products_path
expect(response).to have_http_status(:ok)
end

it "loads stock for every product without an N+1" do
Comment thread
tvdeyen marked this conversation as resolved.
expect { get solidus_admin.products_path }
.to make_database_queries(matching: /from .spree_stock_items./i, count: 1)
Comment thread
tvdeyen marked this conversation as resolved.
end
end

describe "PATCH #update" do
let(:product) { create(:product) }
let(:params) do
Expand Down
Loading