Skip to content

Conversation

@jackstine
Copy link
Contributor

These are just comments. Please add some comments of your own if you like.

@jackstine jackstine marked this pull request as ready for review June 6, 2022 15:24
@jackstine
Copy link
Contributor Author

jackstine commented Jun 6, 2022

/kick build-bot here

@nfuden
Copy link

nfuden commented Jun 6, 2022

nit: Some of these comments are just repeating the exact contents of the functions.
I would argue that method comments should be less implementation linked and talk more about the responsibilities of the method / what it does from a bigger picture.
If you still think that the line by line explantations of functionality (ie using a chan) are needed they can go close to the line itself.

For example with streamenvoyv3 what does it do. It creates a bidirectional stream of envoyv3 configuration which asynchronously retrieves data from the snapshot cache and serves that content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants