fix: integration fixes running in k8s by soluwalana · Pull Request #7 · soluwalana/RL

soluwalana · 2026-08-03T22:20:26Z

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Issues

List issues that this PR closes (syntax):

Usage

You can potentially add a usage example below

# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

Make sure you read and followed Contributor guidelines
Did you write any new necessary tests?
Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

...

github-actions · 2026-08-03T22:21:33Z

❌ Submodule Fast-Forward Check Failed

Check based on commit: 9a11560 (PR #7 from solu/integration-testing)

❌ Submodules that need attention:

Gym: ❌ PR branch is BEHIND nmp/customizer branch
TARGET (nmp/customizer branch): https://github.com/soluwalana/Gym/commits/c55600cac042a2c3081caaa0e2138630bbf21bf2/
CURRENT (PR #7 from solu/integration-testing): https://github.com/soluwalana/Gym/commits/84e6a6d71b6d8b4514d70cf4e9d7e4a0734e1eb7/

Please ensure all submodule commits are fast-forwards of the nmp/customizer branch before merging.

github-actions · 2026-08-03T22:26:04Z

❌ Submodule Fast-Forward Check Failed

Check based on commit: 3aec7ad (PR #7 from solu/integration-testing)

❌ Submodules that need attention:

Gym: ❌ PR branch is BEHIND nmp/customizer branch
TARGET (nmp/customizer branch): https://github.com/soluwalana/Gym/commits/c55600cac042a2c3081caaa0e2138630bbf21bf2/
CURRENT (PR #7 from solu/integration-testing): https://github.com/soluwalana/Gym/commits/84e6a6d71b6d8b4514d70cf4e9d7e4a0734e1eb7/

Please ensure all submodule commits are fast-forwards of the nmp/customizer branch before merging.

Signed-off-by: Sam Oluwalana <soluwalana@nvidia.com>

github-actions · 2026-08-04T17:03:45Z

❌ Submodule Fast-Forward Check Failed

Check based on commit: 5eb30ce (PR #7 from solu/integration-testing)

❌ Submodules that need attention:

Gym: ❌ PR branch is BEHIND nmp/customizer branch
TARGET (nmp/customizer branch): https://github.com/soluwalana/Gym/commits/c55600cac042a2c3081caaa0e2138630bbf21bf2/
CURRENT (PR #7 from solu/integration-testing): https://github.com/soluwalana/Gym/commits/84e6a6d71b6d8b4514d70cf4e9d7e4a0734e1eb7/

Please ensure all submodule commits are fast-forwards of the nmp/customizer branch before merging.

Signed-off-by: Sam Oluwalana <soluwalana@nvidia.com>

github-actions · 2026-08-04T17:12:59Z

❌ Submodule Fast-Forward Check Failed

Check based on commit: e3a3897 (PR #7 from solu/integration-testing)

❌ Submodules that need attention:

Gym: ❌ PR branch is BEHIND nmp/customizer branch
TARGET (nmp/customizer branch): https://github.com/soluwalana/Gym/commits/c55600cac042a2c3081caaa0e2138630bbf21bf2/
CURRENT (PR #7 from solu/integration-testing): https://github.com/soluwalana/Gym/commits/84e6a6d71b6d8b4514d70cf4e9d7e4a0734e1eb7/

Megatron-Bridge: ❌ PR branch is BEHIND nmp/customizer branch
TARGET (nmp/customizer branch): https://github.com/NVIDIA-NeMo/Megatron-Bridge/commits/573e088c9c6740082c39744e03dc5b009e730ed4/
CURRENT (PR #7 from solu/integration-testing): https://github.com/NVIDIA-NeMo/Megatron-Bridge/commits/a056408d29ad1070fb926512991075998c9e023f/

Please ensure all submodule commits are fast-forwards of the nmp/customizer branch before merging.

Signed-off-by: Sam Oluwalana <soluwalana@nvidia.com>

github-actions · 2026-08-04T17:18:10Z

❌ Submodule Fast-Forward Check Failed

Check based on commit: b430330 (PR #7 from solu/integration-testing)

✅ Submodules that are properly updated:

Gym: ✅ PR branch is ahead of nmp/customizer branch (fast-forward)

❌ Submodules that need attention:

Megatron-Bridge: ❌ PR branch is BEHIND nmp/customizer branch
TARGET (nmp/customizer branch): https://github.com/NVIDIA-NeMo/Megatron-Bridge/commits/573e088c9c6740082c39744e03dc5b009e730ed4/
CURRENT (PR #7 from solu/integration-testing): https://github.com/NVIDIA-NeMo/Megatron-Bridge/commits/a056408d29ad1070fb926512991075998c9e023f/

Please ensure all submodule commits are fast-forwards of the nmp/customizer branch before merging.

Signed-off-by: Sam Oluwalana <soluwalana@nvidia.com>

github-actions · 2026-08-04T17:21:25Z

✅ Submodule Fast-Forward Check Results

Check based on commit: b9a0fa5 (PR #7 from solu/integration-testing)

✅ Submodules that are properly updated:

Gym: ✅ PR branch is ahead of nmp/customizer branch (fast-forward)
Megatron-Bridge: ✅ PR branch is ahead of nmp/customizer branch (fast-forward)

All submodule changes look good! ✨

Signed-off-by: Sam O <soluwalana@nvidia.com>

github-actions · 2026-08-04T17:40:04Z

✅ Submodule Fast-Forward Check Results

Check based on commit: 16077bc (PR #7 from solu/integration-testing)

✅ Submodules that are properly updated:

Gym: ✅ PR branch is ahead of nmp/customizer branch (fast-forward)
Megatron-Bridge: ✅ PR branch is ahead of nmp/customizer branch (fast-forward)

All submodule changes look good! ✨

Signed-off-by: Sam Oluwalana <soluwalana@nvidia.com>

github-actions · 2026-08-04T18:10:47Z

✅ Submodule Fast-Forward Check Results

Check based on commit: 32fe6ba (PR #7 from solu/integration-testing)

✅ Submodules that are properly updated:

Gym: ✅ PR branch is ahead of nmp/customizer branch (fast-forward)
Megatron-Bridge: ✅ PR branch is ahead of nmp/customizer branch (fast-forward)

All submodule changes look good! ✨

Signed-off-by: Sam O <soluwalana@nvidia.com>

github-actions · 2026-08-04T18:21:18Z

✅ Submodule Fast-Forward Check Results

Check based on commit: e073474 (PR #7 from solu/integration-testing)

✅ Submodules that are properly updated:

Gym: ✅ PR branch is ahead of nmp/customizer branch (fast-forward)
Megatron-Bridge: ✅ PR branch is ahead of nmp/customizer branch (fast-forward)

All submodule changes look good! ✨

anubhutivyas · 2026-08-04T18:31:14Z

+            normalized = str(key).lower()
+            if (
+                normalized in _SENSITIVE_CONFIG_KEYS
+                or normalized.endswith("_api_key")


nit: can we also have a dict to check the endswith strings?

anubhutivyas · 2026-08-04T18:38:32Z

+        # Sync GRPO does not tear down env actors itself. Always drain them so
+        # OpenSandbox Gym hosts and episode sandboxes are destroyed (not left to TTL).
+        # Async GRPO also shuts envs down; repeated shutdown is idempotent.
+        seen_envs: set[int] = set()


can we not call the same _shutdown_environments method here?

anubhutivyas · 2026-08-04T18:40:19Z

+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+"""Default entrypoint for the sandboxed Gym host inside the training image.


do we still need it after the fixes in #8 and NVIDIA-NeMo/nemo-platform#1056?

We will likely need to update the entrypoint after 8

soluwalana added 2 commits August 4, 2026 11:02

fix: integration fixes running in k8s

49c2688

Signed-off-by: Sam Oluwalana <soluwalana@nvidia.com>

Add workaround text

5eb30ce

Signed-off-by: Sam Oluwalana <soluwalana@nvidia.com>

soluwalana force-pushed the solu/integration-testing branch from 3aec7ad to 5eb30ce Compare August 4, 2026 17:02

rebase artifacts

e3a3897

Signed-off-by: Sam Oluwalana <soluwalana@nvidia.com>

Update gym

b430330

Signed-off-by: Sam Oluwalana <soluwalana@nvidia.com>

Update the megatron bridge sha

b9a0fa5

Signed-off-by: Sam Oluwalana <soluwalana@nvidia.com>

uv.lock

16077bc

Signed-off-by: Sam O <soluwalana@nvidia.com>

>

32fe6ba

Signed-off-by: Sam Oluwalana <soluwalana@nvidia.com>

soluwalana added 2 commits August 4, 2026 12:19

>

7ce46e9

Signed-off-by: Sam O <soluwalana@nvidia.com>

>

e073474

Signed-off-by: Sam O <soluwalana@nvidia.com>

anubhutivyas reviewed Aug 4, 2026

View reviewed changes

Navigation Menu

fix: integration fixes running in k8s - #7

fix: integration fixes running in k8s#7
soluwalana wants to merge 9 commits into
nmp/customizerfrom
solu/integration-testing

soluwalana commented Aug 3, 2026

Uh oh!

github-actions Bot commented Aug 3, 2026

Uh oh!

github-actions Bot commented Aug 3, 2026

Uh oh!

github-actions Bot commented Aug 4, 2026

Uh oh!

github-actions Bot commented Aug 4, 2026

Uh oh!

github-actions Bot commented Aug 4, 2026

Uh oh!

github-actions Bot commented Aug 4, 2026

Uh oh!

github-actions Bot commented Aug 4, 2026

Uh oh!

github-actions Bot commented Aug 4, 2026

Uh oh!

github-actions Bot commented Aug 4, 2026

Uh oh!

anubhutivyas Aug 4, 2026

Uh oh!

anubhutivyas Aug 4, 2026

Uh oh!

anubhutivyas Aug 4, 2026

Uh oh!

soluwalana Aug 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

soluwalana commented Aug 3, 2026

What does this PR do ?

Issues

Usage

Before your PR is "Ready for review"

Additional Information

Uh oh!

github-actions Bot commented Aug 3, 2026

❌ Submodule Fast-Forward Check Failed

❌ Submodules that need attention:

Uh oh!

github-actions Bot commented Aug 3, 2026

❌ Submodule Fast-Forward Check Failed

❌ Submodules that need attention:

Uh oh!

github-actions Bot commented Aug 4, 2026

❌ Submodule Fast-Forward Check Failed

❌ Submodules that need attention:

Uh oh!

github-actions Bot commented Aug 4, 2026

❌ Submodule Fast-Forward Check Failed

❌ Submodules that need attention:

Uh oh!

github-actions Bot commented Aug 4, 2026

❌ Submodule Fast-Forward Check Failed

✅ Submodules that are properly updated:

❌ Submodules that need attention:

Uh oh!

github-actions Bot commented Aug 4, 2026

✅ Submodule Fast-Forward Check Results

✅ Submodules that are properly updated:

Uh oh!

github-actions Bot commented Aug 4, 2026

✅ Submodule Fast-Forward Check Results

✅ Submodules that are properly updated:

Uh oh!

github-actions Bot commented Aug 4, 2026

✅ Submodule Fast-Forward Check Results

✅ Submodules that are properly updated:

Uh oh!

github-actions Bot commented Aug 4, 2026

✅ Submodule Fast-Forward Check Results

✅ Submodules that are properly updated:

Uh oh!

anubhutivyas Aug 4, 2026

Choose a reason for hiding this comment

Uh oh!

anubhutivyas Aug 4, 2026

Choose a reason for hiding this comment

Uh oh!

anubhutivyas Aug 4, 2026

Choose a reason for hiding this comment

Uh oh!

soluwalana Aug 5, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants