Open
Conversation
yungyuc
requested changes
Aug 27, 2021
|
|
||
| test_get_list_type() { | ||
| expected="get_list is a function" | ||
| actual=$(type get_list | grep "is a") |
Member
There was a problem hiding this comment.
How about testing the return of get_list instead of checking the type? bash does not have a lot of types so it is probably not very informative.
There are currently 4 kinds of lists to be returned from get_list: flavor, build, application, and cmd. "flavor" and "cmd" may be more useful than others.
Member
There was a problem hiding this comment.
@YenPeiChen07 Another month passed. Is there any update?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a test
test_get_list_type()intests/test_bash_utils.shto test whether theget_listis a function.Because I found
displayandget_listare the functions defined inbash_utilsfile, but there is just a test fordisplayintests/test_bash_utils.sh. Thus, I add one forget_list.Here is the test I added:
The tests are passed after running
./runner.shAny suggestions and comments are welcome!