Feature/pfc hardware recovery hld #2159
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
- Comprehensive design document for hardware-based PFC recovery - Includes architecture refactoring proposal with PfcWdHwOrch - New CLI command: show pfcwd status with hardware-specific information - SAI attributes and implementation details for hardware recovery - Flow diagrams for hardware vs software recovery decision and workflow - Testing requirements and validation approach - Hardware timer granularity constraints and actual vs configured values - Comparison table highlighting differences between software and hardware recovery Signed-off-by: Pinky Agrawal <pinky@nexthop.ai>
- Changed 'CLI/YANG' to 'CLI-YANG' to fix markdown anchor link - Forward slash in header was breaking clickable navigation Signed-off-by: Pinky Agrawal <pinky@nexthop.ai>
- Updated TOC to reflect actual document structure - Removed non-existent subsections 12.2, 12.3, 12.4 - Only section 12.1 exists in the streamlined testing section Signed-off-by: Pinky Agrawal <pinky@nexthop.ai>
- Better accuracy in storm detection and restoration timing - Reduced latency compared to software polling-based approach - Lower CPU overhead by eliminating continuous software polling - Hardware operates at line rate without software delays Signed-off-by: Pinky Agrawal <pinky@nexthop.ai>
- Section 13 Open Points does not exist in the document - Cleaned up Table of Contents to match actual document structure Signed-off-by: Pinky Agrawal <pinky@nexthop.ai>
- Added CLI Data Flow subsection to TOC for proper navigation - Fixes parsing/navigation issue in section 5 Signed-off-by: Pinky Agrawal <pinky@nexthop.ai>
- Simplified the display table description in mermaid flowchart - Removed pipe characters that could cause parsing issues - Improved readability of the CLI data flow diagram Signed-off-by: Pinky Agrawal <pinky@nexthop.ai>
- Created doc/pfcwd/ directory for PFC Watchdog documentation - Moved pfc_hardware_recovery_hld.md from doc/qos/ to doc/pfcwd/ - Better organization following SONiC documentation structure - Dedicated directory allows for future PFC Watchdog related documents Signed-off-by: Pinky Agrawal <pinky@nexthop.ai>
pinky-nexthop
force-pushed
the
feature/pfc-hardware-recovery-hld
branch
from
d793e08 to
ee7c047
Compare
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
- Added STATUS column to show pfcwd status command output to indicate success/failed programming status - Updated CLI data flow diagram to include status validation - Added example showing failed configuration due to unsupported timer ranges - Updated hardware recovery workflow diagram to show event notification happening immediately after storm detection - Added conditional logic for app_managed_recovery flag: - If true: wait for SAI_QUEUE_ATTR_PFC_DLR_INIT programming - If false: hardware automatically applies recovery action Signed-off-by: Pinky Agrawal <pinky@nexthop.ai>
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a comprehensive High Level Design document for PFC Watchdog Hardware Recovery feature that provides better accuracy in storm detection and restoration compared to software-based approaches.
Key Features
show pfcwd statuswith hardware-specific information including actual timer values and granularityHardware Recovery Advantages
Document Structure
doc/pfcwd/directory.Technical Highlights
Review Focus Areas