Handle routes using link local nexthop#156
Open
yue-fred-gao wants to merge 4 commits intosonic-net:mainfrom
Open
Handle routes using link local nexthop#156yue-fred-gao wants to merge 4 commits intosonic-net:mainfrom
yue-fred-gao wants to merge 4 commits intosonic-net:mainfrom
Conversation
- ipv6 link local addess is enabled by default in SONIC - Remove manifest.json, which is generated from build - correct indentation in SaiVppXlate.c
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
why
When we add a route, the current code doesn't provide interface to vl_api_ip_route_add_del but only provides nexthop address. It works with if the nexthop address is unique. However, in link-local case, the nexthop address is not unique and only valid with the egress interface. vpp fails to find the correct nexthop and interface.
what this PR does
SAI provides SAI_NEXT_HOP_ATTR_ROUTER_INTERFACE_ID. We can get the egress interface from this attribute and provide it to vpp in the vl_api_ip_route_add_del. This removes the ambiguity in the link-local case.