[9.14.r1] Add appended DTB support #2475
Draft
konradybcio wants to merge 2 commits into
Draft
Conversation
Apparently nobody seems to have tested clang 13 before release, as the whole coding paradigm of calling a function by assigning its return value to a variable, which is used all throughout the Linux kernel, becomes broken, as clang seems utterly drunk when it comes to the actual judgement whether the variable is really used or not..
Contributor
Author
|
required configs: |
MarijnS95
reviewed
Dec 28, 2021
Comment on lines
+149
to
+154
| ifeq ($(CONFIG_BUILD_ARM64_APPENDED_DTB_IMAGE),y) | ||
| # Warning! Uncompressed kernel + appended DTB + DTBO WILL NOT WORK! | ||
| KBUILD_IMAGE := $(KBUILD_TARGET)-dtb | ||
| else | ||
| KBUILD_IMAGE := $(KBUILD_TARGET) | ||
| endif |
Contributor
There was a problem hiding this comment.
The original commit has this inside ifeq ($(CONFIG_BUILD_ARM64_KERNEL_COMPRESSION_GZIP),y).
Contributor
Author
There was a problem hiding this comment.
this way it will work with uncompressed kernel without dtbo
Contributor
There was a problem hiding this comment.
I dout uncompressed kernel + appended dtb works? Does it?
MarijnS95
reviewed
Dec 28, 2021
Comment on lines
+35
to
+51
| dtb-$(CONFIG_OF_ALL_DTBS) := $(patsubst $(dtstree)/%.dts,%.dtb, $(foreach d,$(subdir), $(wildcard $(dtstree)/$(d)/*.dts))) | ||
|
|
||
| always := $(dtb-y) | ||
|
|
||
| targets += dtbs | ||
|
|
||
| DTB_NAMES := $(subst $\",,$(CONFIG_BUILD_ARM64_APPENDED_DTB_IMAGE_NAMES)) | ||
| ifneq ($(DTB_NAMES),) | ||
| DTB_LIST := $(addsuffix .dtb,$(DTB_NAMES)) | ||
| else | ||
| DTB_LIST := $(dtb-y) | ||
| endif | ||
| targets += $(DTB_LIST) | ||
|
|
||
| dtbs: $(addprefix $(obj)/, $(DTB_LIST)) | ||
|
|
||
| clean-files := dts/*.dtb *.dtb |
Contributor
There was a problem hiding this comment.
This was moved to arch/arm64/boot/Makefile.
Contributor
|
With |
Contributor
Author
|
setting as draft in case somebody wants to pick this up for new (old) devices |
konradybcio
changed the title
Allows a defconfig to set a list of dtbs to concatenate with an Image.gz to create a Image.gz-dtb. Includes 8adb162 arm64: Fix correct dtb clean-files location Change-Id: I0b462322d5c970f1fdf37baffece7ad058099f4a Signed-off-by: Alex Ray <aray@google.com> [rishabhb] Use subdir to descend into device tree directories Signed-off-by: Rishabh Bhatnagar <rishabhb@codeaurora.org> konrad: fast-forward it to msm-5.4
jerpelea
force-pushed
the
aosp/LA.UM.9.14.r1
branch
from
1db68e9 to
3ce8db7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.