Refactor observation statistics processing and discard recent observations without telemetry#208
Open
javierggt wants to merge 17 commits into
Open
Refactor observation statistics processing and discard recent observations without telemetry#208javierggt wants to merge 17 commits into
javierggt wants to merge 17 commits into
Conversation
…_supplement.get_agasc_id_stats
…always, and then ignore them when writing the file
…ut of get_multi_obs_stats
…_table is True and no exception has been raised by the end, ignore all entries with errors, as this implies ignore_exceptions is true
…are no observations in stats
Member
|
What's happening on this? |
Contributor
Author
|
If you check the output you will see that this PR is ok as far as labeling "no-telemetry" observations, but every once in a while there are observations that fail with an unspecified error (like this). On Wednesday I tried, and got no error processing those failed observations, so I don't know why they failed. I added some debug output to check on Monday. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the way obs-stats are calculated to disentangle it from the agasc_stats (the supplement is based on stars, so the processing did not allow direct processing of observations independently).
After that, I fixed a few issues:
Interface impacts
Testing
Unit tests
Independent check of unit tests by [REVIEWER NAME]
Functional tests
Running weekly update in test environment. Output: