Always use call_args.yml to store arguments in supplement report#210
Open
javierggt wants to merge 1 commit into
Open
Always use call_args.yml to store arguments in supplement report#210javierggt wants to merge 1 commit into
javierggt wants to merge 1 commit into
Conversation
…lename to store call arguments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The agasc supplement update always runs in the same directory, and it always generates a file with the command-line arguments. This file is called call-args.yml by default, but if the file already exists it is called
call_args.<N>.yml. It checks which is the last call-args file and sets N to not overwrite an existing file. At the end of the run, the file is moved to the reports directory.The issue in #209:
call_args.<N>.ymlThe fix: always rename the file that is placed in the reports directory so it is the expected name.
It is not clear why there were call-args files in the work directory to begin with, because they are supposed to be moved. Maybe this happened when I tried debugging something and left a file.
Fixes #209
Interface impacts
Testing
Unit tests
Independent check of unit tests by [REVIEWER NAME]
Functional tests
No functional testing.