Skip to content

Always use call_args.yml to store arguments in supplement report#210

Open
javierggt wants to merge 1 commit into
masterfrom
call-args-filename
Open

Always use call_args.yml to store arguments in supplement report#210
javierggt wants to merge 1 commit into
masterfrom
call-args-filename

Conversation

@javierggt
Copy link
Copy Markdown
Contributor

@javierggt javierggt commented May 22, 2026

Description

The agasc supplement update always runs in the same directory, and it always generates a file with the command-line arguments. This file is called call-args.yml by default, but if the file already exists it is called call_args.<N>.yml. It checks which is the last call-args file and sets N to not overwrite an existing file. At the end of the run, the file is moved to the reports directory.

The issue in #209:

  • When making dispositions, the script expects a file called call-args.yml in the reports directory
  • if there were already args files in the working directory, the file is not called call_args.yml but call_args.<N>.yml
  • the script fails.

The fix: always rename the file that is placed in the reports directory so it is the expected name.

It is not clear why there were call-args files in the work directory to begin with, because they are supposed to be moved. Maybe this happened when I tried debugging something and left a file.

Fixes #209

Interface impacts

Testing

Unit tests

  • No unit tests
  • Mac
  • Linux
  • Windows
(ska3-flight) ~/SAO/git/agasc call-args-filename $ git rev-parse HEAD
1d6d2e03a1062397186ea80a1d9e278d9207fd1f
(ska3-flight) ~/SAO/git/agasc call-args-filename $ pytest agasc
===================================================================== test session starts =====================================================================
platform darwin -- Python 3.13.11, pytest-9.0.2, pluggy-1.6.0
rootdir: /Users/javierg/SAO/git
configfile: pytest.ini
plugins: anyio-4.12.1, timeout-2.4.0
collected 79 items                                                                                                                                            

agasc/tests/test_agasc_1.py .......                                                                                                                     [  8%]
agasc/tests/test_agasc_2.py ..........sssss..........ss....................                                                                             [ 68%]
agasc/tests/test_agasc_healpix.py .ssssssssss                                                                                                           [ 82%]
agasc/tests/test_obs_status.py ..............                                                                                                           [100%]

=============================================================== 62 passed, 17 skipped in 8.99s ================================================================

Independent check of unit tests by [REVIEWER NAME]

  • [PLATFORM]:

Functional tests

No functional testing.

@javierggt javierggt requested a review from jeanconn May 22, 2026 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dispositions failed

1 participant