fix(cli): NO_COLOR/non-TTY output, golden-path help, heartbeat 403 re-enroll#116
Open
secxena wants to merge 1 commit into
Open
fix(cli): NO_COLOR/non-TTY output, golden-path help, heartbeat 403 re-enroll#116secxena wants to merge 1 commit into
secxena wants to merge 1 commit into
Conversation
… re-enroll
UX/usability fixes from the CLI audit:
1. NO_COLOR / non-TTY: style::{success,warning,info,kv,highlight,
success_prefix} now gate ANSI through logging::use_ansi_colors()
(NO_COLOR env + IsTerminal on stdout), plain-printing into pipes/CI.
2. Golden path in help: add a "GETTING STARTED" after_help block to the
top-level command (standalone: setup-ca -> up; cloud: setup-ca ->
enroll -> up) and reorder subcommands so the one-shot `up` bootstrap
is listed first. `soth init` next-steps now include the `enroll` step
so cloud users don't dead-end at bundle bootstrap.
3. Heartbeat 403 visibility + re-enroll escape hatch: persist the last
heartbeat rejection (status + message + endpoint) to a run-dir sidecar
(~/.soth/run/heartbeat_rejection.json), cleared on the next accepted
heartbeat. Surface it in `soth status` (SYNC section + degraded health)
and `soth doctor` (new CLOUD section + error finding), each with a
re-enroll remediation. Add `soth enroll --new-device-id` to regenerate
the stale device_id that reproduces the org-mismatch 403.
Tests: device-id regeneration (cli_config), cloud heartbeat findings
(doctor), rejection sidecar roundtrip (soth-sync). cargo build -p
soth-cli and cargo test -p soth-cli green (127 + 9 passed).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UX/usability fixes from the CLI audit (soth edge proxy,
crates/soth-cli).1. NO_COLOR / non-TTY output
style::{success,warning,info,kv,highlight,success_prefix}emitted unconditional ANSI even into pipes/CI/NO_COLOR. They now gate through the existinglogging::use_ansi_colors()(honorsNO_COLORenv +std::io::IsTerminalon stdout) and plain-print when color is off. Fleet-wide payoff for piped/CI output.2. Golden path in help
GETTING STARTEDafter_helpblock to the top-level command: standalone (setup-ca->up) and cloud (setup-ca->enroll->up) paths.soth upbootstrap is listed first (was buried afterstart/stop).soth initnumbered next-steps now include theenrollstep so cloud users don't dead-end at bundle bootstrap.3. Heartbeat 403 visibility + re-enroll escape hatch
The known org-mismatch pain: a sync heartbeat 403 was only a daemon
warn!,soth statusshowed "Last heartbeat: never" with no cause, andsoth doctorhad no cloud/auth check.soth_sync::heartbeat_rejectionsidecar (~/.soth/run/heartbeat_rejection.json): persisted on any non-2xx heartbeat (status + message + endpoint), cleared on the next accepted heartbeat. Best-effort — never aborts the heartbeat loop.soth status: SYNC section now showsHeartbeat: REJECTED (HTTP 403, ...)with asoth enroll --new-device-id <token>fix line, and folds the rejection into the degraded/health verdict.soth doctor: new CLOUD section + anerrorfinding (cloud_heartbeat_rejected) with the re-enroll remediation.soth enroll --new-device-id: regenerates the client device id before the exchange (default reuses the stale, cloud-rejected id, reproducing the same 403).Verification
cargo build -p soth-cli— green.cargo test -p soth-cli— 127 + 9 passed, 0 failed.cargo test -p soth-sync --lib heartbeat_rejection— passed.🤖 Generated with Claude Code