Skip to content

Add deprecation message for waiters using deprecated operations #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adam-fowler merged 2 commits into from
Dec 11, 2025
Merged

Add deprecation message for waiters using deprecated operations #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21f3fc4
Add deprecation message to waiters
adam-fowler Dec 2, 2025
a481845
swift-format
adam-fowler Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions Sources/SotoCodeGeneratorLib/Model+Patch.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ extension Model {
patch: AddTraitPatch(trait: EnumTrait(value: .init([.init(value: "HTTP1_1"), .init(value: "HTTP2")])))
),
"com.amazonaws.cloudfront#DistributionSummary$HttpVersion": EditShapePatch { (shape: MemberShape) in
return MemberShape(target: "com.amazonaws.cloudfront#UppercaseHttpVersion", traits: shape.traits)
MemberShape(target: "com.amazonaws.cloudfront#UppercaseHttpVersion", traits: shape.traits)
},
],
"CloudWatch": [
Expand All @@ -67,7 +67,7 @@ extension Model {
"DynamoDB": [
// Make TransactWriteItem an enum with associated values
"com.amazonaws.dynamodb#TransactWriteItem": EditShapePatch { (shape: StructureShape) in
return UnionShape(traits: shape.traits, members: shape.members)
UnionShape(traits: shape.traits, members: shape.members)
}
],
"EC2": [
Expand Down Expand Up @@ -116,7 +116,7 @@ extension Model {
)
),
"com.amazonaws.lambda#ListFunctionsRequest$MasterRegion": EditShapePatch { (shape: MemberShape) in
return MemberShape(target: "com.amazonaws.lambda#SotoCore.Region", traits: shape.traits)
MemberShape(target: "com.amazonaws.lambda#SotoCore.Region", traits: shape.traits)
},
// https://github.com/soto-project/soto/issues/720
"com.amazonaws.lambda#LastUpdateStatusReasonCode": AddShapeMemberPatch<EnumShape>(
Expand All @@ -134,7 +134,7 @@ extension Model {
],
"RDSData": [
// See https://github.com/soto-project/soto/issues/471
"com.amazonaws.rdsdata#Arn": EditTraitPatch { trait in return LengthTrait(min: trait.min, max: 2048) }
"com.amazonaws.rdsdata#Arn": EditTraitPatch { trait in LengthTrait(min: trait.min, max: 2048) }
],
"Route53": [
// pagination tokens in response shouldnt be required
Expand All @@ -144,7 +144,7 @@ extension Model {
],
"S3": [
// https://github.com/soto-project/soto/issues/311
"com.amazonaws.s3#CopySource": EditTraitPatch { _ in return PatternTrait(value: ".+\\/.+") },
"com.amazonaws.s3#CopySource": EditTraitPatch { _ in PatternTrait(value: ".+\\/.+") },
"com.amazonaws.s3#LifecycleRule$Filter": AddTraitPatch(trait: RequiredTrait()),
// https://github.com/soto-project/soto/issues/502
"com.amazonaws.s3#BucketLocationConstraint": MultiplePatch(
Expand Down
6 changes: 6 additions & 0 deletions Sources/SotoCodeGeneratorLib/Templates/waiters.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ extension Templates {
/// - Parameters:
/// - input: Input for operation
/// - logger: Logger used for logging
{{#operation.deprecated}}
@available(*, deprecated, message: "{{.}}")
{{/operation.deprecated}}
@inlinable
{{scope}} func waitUntil{{waiterName}}(
_ input: {{operation.inputShape}},
Expand Down Expand Up @@ -72,6 +75,9 @@ extension Templates {
/// - {{parameter}}: {{first(comment)}}
{{/operation.initParameters}}
/// - logger: Logger used for logging
{{#operation.deprecated}}
@available(*, deprecated, message: "{{.}}")
{{/operation.deprecated}}
@inlinable
{{scope}} func waitUntil{{waiterName}}(
{{#operation.initParameters}}
Expand Down