Skip to content

[BUGFIX] Refine file reference handling for POST requests #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kszymukowicz merged 1 commit into from
Jul 27, 2025
Merged

[BUGFIX] Refine file reference handling for POST requests #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 45 additions & 15 deletions .ddev/test/files/src/t3apinews/Classes/Domain/Model/News.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,9 @@ class News extends \GeorgRinger\News\Domain\Model\News
* @T3api\Serializer\Groups({
* "api_get_collection_t3apinews_news",
* "api_get_item_t3apinews_news",
* "api_post_item_t3apinews_news",
* "api_patch_item_t3apinews_news",
* "api_put_item_t3apinews_news",
* })
*/
protected $teaser = '';
Expand All @@ -148,6 +151,8 @@ class News extends \GeorgRinger\News\Domain\Model\News
* @T3api\Serializer\Groups({
* "api_get_item_t3apinews_news",
* "api_post_item_t3apinews_news",
* "api_patch_item_t3apinews_news",
* "api_put_item_t3apinews_news",
* })
*/
protected $bodytext = '';
Expand All @@ -156,20 +161,20 @@ class News extends \GeorgRinger\News\Domain\Model\News
* @var \DateTime
* @T3api\Serializer\Groups({
* "api_get_collection_t3apinews_news",
* "api_get_item_t3apinews_news",
* "api_post_item_t3apinews_news",
* "api_patch_item_t3apinews_news",
* "api_put_item_t3apinews_news",
* "api_get_item_t3apinews_news",
* "api_post_item_t3apinews_news",
* "api_patch_item_t3apinews_news",
* "api_put_item_t3apinews_news",
* })
*/
protected $datetime;

/**
* @var \Datetime
* @T3api\Serializer\Groups({
* "api_post_item_t3apinews_news",
* "api_patch_item_t3apinews_news",
* "api_put_item_t3apinews_news",
* "api_post_item_t3apinews_news",
* "api_patch_item_t3apinews_news",
* "api_put_item_t3apinews_news",
* })
*/
protected $crdate;
Expand All @@ -179,6 +184,9 @@ class News extends \GeorgRinger\News\Domain\Model\News
* @T3api\Serializer\Groups({
* "api_get_collection_t3apinews_news",
* "api_get_item_t3apinews_news",
* "api_post_item_t3apinews_news",
* "api_patch_item_t3apinews_news",
* "api_put_item_t3apinews_news",
* })
*/
protected $author = '';
Expand All @@ -188,6 +196,9 @@ class News extends \GeorgRinger\News\Domain\Model\News
* @T3api\Serializer\Groups({
* "api_get_collection_t3apinews_news",
* "api_get_item_t3apinews_news",
* "api_post_item_t3apinews_news",
* "api_patch_item_t3apinews_news",
* "api_put_item_t3apinews_news",
* })
*/
protected $authorEmail = '';
Expand All @@ -207,21 +218,21 @@ class News extends \GeorgRinger\News\Domain\Model\News
/**
* @var \TYPO3\CMS\Extbase\Persistence\ObjectStorage<\SourceBroker\T3apinews\Domain\Model\News>
* @T3api\Serializer\Groups({
* "api_get_item_t3apinews_news",
* "api_post_item_t3apinews_news",
* "api_patch_item_t3apinews_news",
* "api_put_item_t3apinews_news",
* "api_get_item_t3apinews_news",
* "api_post_item_t3apinews_news",
* "api_patch_item_t3apinews_news",
* "api_put_item_t3apinews_news",
* })
*/
protected $related;

/**
* @var \TYPO3\CMS\Extbase\Persistence\ObjectStorage<\SourceBroker\T3apinews\Domain\Model\News>
* @T3api\Serializer\Groups({
* "api_get_item_t3apinews_news",
* "api_post_item_t3apinews_news",
* "api_patch_item_t3apinews_news",
* "api_put_item_t3apinews_news",
* "api_get_item_t3apinews_news",
* "api_post_item_t3apinews_news",
* "api_patch_item_t3apinews_news",
* "api_put_item_t3apinews_news",
* })
*/
protected $relatedFrom;
Expand All @@ -231,13 +242,18 @@ class News extends \GeorgRinger\News\Domain\Model\News
* @T3api\Serializer\Groups({
* "api_get_collection_t3apinews_news",
* "api_get_item_t3apinews_news",
* "api_post_item_t3apinews_news",
* "api_patch_item_t3apinews_news",
* "api_put_item_t3apinews_news",
* })
*/
protected $type = '';

/**
* @var string
* @T3api\Serializer\Groups({
* "api_get_collection_t3apinews_news",
* "api_get_item_t3apinews_news",
* "api_post_item_t3apinews_news",
* "api_patch_item_t3apinews_news",
* "api_put_item_t3apinews_news",
Expand All @@ -249,6 +265,9 @@ class News extends \GeorgRinger\News\Domain\Model\News
* @T3api\Serializer\Groups({
* "api_get_collection_t3apinews_news",
* "api_get_item_t3apinews_news",
* "api_post_item_t3apinews_news",
* "api_patch_item_t3apinews_news",
* "api_put_item_t3apinews_news",
* })
*/
protected $internalurl = '';
Expand All @@ -258,6 +277,9 @@ class News extends \GeorgRinger\News\Domain\Model\News
* @T3api\Serializer\Groups({
* "api_get_collection_t3apinews_news",
* "api_get_item_t3apinews_news",
* "api_post_item_t3apinews_news",
* "api_patch_item_t3apinews_news",
* "api_put_item_t3apinews_news",
* })
*/
protected $externalurl = '';
Expand All @@ -267,6 +289,9 @@ class News extends \GeorgRinger\News\Domain\Model\News
* @T3api\Serializer\Groups({
* "api_get_collection_t3apinews_news",
* "api_get_item_t3apinews_news",
* "api_post_item_t3apinews_news",
* "api_patch_item_t3apinews_news",
* "api_put_item_t3apinews_news",
* })
*/
protected $istopnews = false;
Expand All @@ -276,6 +301,9 @@ class News extends \GeorgRinger\News\Domain\Model\News
* @T3api\Serializer\Groups({
* "api_get_collection_t3apinews_news",
* "api_get_item_t3apinews_news",
* "api_post_item_t3apinews_news",
* "api_patch_item_t3apinews_news",
* "api_put_item_t3apinews_news",
* })
*/
protected \TYPO3\CMS\Extbase\Persistence\ObjectStorage $tags;
Expand All @@ -285,7 +313,9 @@ class News extends \GeorgRinger\News\Domain\Model\News
* @T3api\Serializer\Groups({
* "api_get_collection_t3apinews_news",
* "api_get_item_t3apinews_news",
* "api_post_item_t3apinews_news",
* "api_patch_item_t3apinews_news",
* "api_put_item_t3apinews_news",
* })
*/
protected $falMedia;
Expand Down
2 changes: 1 addition & 1 deletion Classes/Serializer/Handler/FileReferenceHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ protected function createSysFileReference(
if ($visitor->getCurrentObject() instanceof AbstractDomainObject) {
/** @var AbstractDomainObject $currentObject */
$currentObject = $visitor->getCurrentObject();
$fileReference->setPid($currentObject->getPid());
$fileReference->setPid($currentObject->getPid() ?? 0);
$fileReference->_setProperty('_languageUid', $currentObject->_getProperty('_languageUid'));
}

Expand Down
2 changes: 1 addition & 1 deletion README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ At frontend part you can at once test REST API responses for ext news:
* https://13.t3api.ddev.site/_api/news/categories
* etc

You can also run Postman test with ``ddev ci:tests:postman`` command or full test suite with ``ddev composer ci``.
You can also run Postman test with ``ddev composer ci:tests:postman`` command or full test suite with ``ddev composer ci``.
Postman is doing full CRUD test with category and news (with image).

Development
Expand Down
Loading