Skip to content

Conversation

@mithom
Copy link
Contributor

@mithom mithom commented Dec 18, 2025

  • adds a log entry for background fetches as they are git commands being run by user configuration of the application.
  • in background fetches there is no possibility to choose between with or without tags. This needs to either be a user configuration, or use the 'tagOpt' git configuration (which it does by default when not specifying an option). To achieve this we need a third value for noTags, namely default. i introduced this through a nullable value with null being the 3th value.

possible changes to this PR:

  • split the commit into 2 commits/PR's (but since it's so small i thought it wouldn't be an issue)
  • introduce an enum instead of using null as a value
  • make a repo or global configuration for the noTags in the background fetch.

if you want any of the mentioned changes (or any other), please let me know.

…(since you have no explicit option to use)

ammend: fix formatting
@mithom
Copy link
Contributor Author

mithom commented Dec 18, 2025

the failed task is due to a timeout on the fetching of 'actions/download-artifact@v4'
and is not specific to this PR

love-linger added a commit that referenced this pull request Dec 19, 2025
@love-linger
Copy link
Collaborator

I've pushed my implementation of this feature.

love-linger added a commit that referenced this pull request Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants