transparently simplify control flow#83
Merged
keegancsmith merged 1 commit intosourcegraph:masterfrom Feb 17, 2025
Merged
Conversation
| case m.response != nil: | ||
| resp := m.response | ||
| if resp != nil { |
Contributor
Author
There was a problem hiding this comment.
The nested if is unnecessary, since the switch case just proved that the response is non-nil.
Comment on lines
-426
to
-431
| if err := checkType(&msg{ | ||
| ID: msgs[i].ID, | ||
| Method: msgs[i].Method, | ||
| Result: msgs[i].Result, | ||
| Error: msgs[i].Error, | ||
| }); err != nil { |
Contributor
Author
There was a problem hiding this comment.
No need to construct a new msg literal, since the result is identical to what is already in msgs[i].
Comment on lines
-121
to
-124
| switch name { | ||
| case "id", "jsonrpc", "meta", "method", "params": | ||
| continue | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Through use of pop (and delete), none of these fields will be present.
keegancsmith
approved these changes
Feb 17, 2025
| if err != nil { | ||
| break | ||
| c.close(err) | ||
| return |
Member
There was a problem hiding this comment.
nice I looked at the old code and have no idea why we structured it that way. Thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is behaviorally transparent: existing tests pass.
This will be easier to review in hide-whitespace mode.