Skip to content

Conversation

@BobSolyman
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Oct 4, 2021

❌ Deploy Preview for switch-me failed.

🔨 Explore the source changes: 5635740

🔍 Inspect the deploy log: https://app.netlify.com/sites/switch-me/deploys/61635801c2c42700084bf0fd

Andrew51234 and others added 4 commits October 6, 2021 22:11
'-webkit-center' property was not recognized by Firefox so '-moz-center'
was added as a fallback
Added a GitHub action to automatically run code styles checks for each submitted pull request
@lothemar
Copy link
Contributor

lothemar commented Oct 9, 2021

@BobSolyman couple of comments:

Navbar has /account but the route is on /profile, I'm not sure what exact name for this was, but both work, so just align them together.

Navbar's second dead link is /filter. I believe this is supposed to redirect to the dashboard?

404's aren't raised on non-existent routes when I try it out on netlify. Is this an option we can enable in react-router? CC: @alyyasser19

Just a simple centered h3 saying 404 would be fine, nothing too fancy.

Other than that, it looks clean!

@lothemar
Copy link
Contributor

lothemar commented Oct 9, 2021

@BobSolyman rebase onto the latest main & make sure the PR is green with our automated GitHub actions so we can merge

@lothemar lothemar force-pushed the main branch 3 times, most recently from d65eae2 to 6a7285d Compare October 15, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants