Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ file(WRITE "${CMAKE_CURRENT_BINARY_DIR}/VERSION" "${ONE_VERSION}")
if(ONE_INDEX OR ONE_SERVER)
add_subdirectory(src/shared)
add_subdirectory(src/gzip)
add_subdirectory(src/metapack)
endif()

if(ONE_INDEX)
Expand Down Expand Up @@ -121,6 +122,7 @@ if(ONE_TESTS)

if(ONE_INDEX OR ONE_SERVER)
add_subdirectory(test/unit/gzip)
add_subdirectory(test/unit/metapack)
endif()

if(ONE_INDEX)
Expand Down
2 changes: 1 addition & 1 deletion contrib/file2metapack/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ sourcemeta_executable(NAMESPACE sourcemeta PROJECT one NAME file2metapack
SOURCES file2metapack.cc)

target_link_libraries(sourcemeta_one_file2metapack
PRIVATE sourcemeta::one::shared)
PRIVATE sourcemeta::one::metapack)
target_link_libraries(sourcemeta_one_file2metapack
PRIVATE sourcemeta::core::options)

Expand Down
10 changes: 5 additions & 5 deletions contrib/file2metapack/file2metapack.cc
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#include <sourcemeta/core/options.h>
#include <sourcemeta/one/shared.h>
#include <sourcemeta/one/metapack.h>

#include <cstdlib> // EXIT_FAILURE, EXIT_SUCCESS
#include <exception> // std::exception
Expand All @@ -18,11 +18,11 @@ auto main(int argc, char *argv[]) noexcept -> int {

const std::filesystem::path output{app.positional().at(2)};
std::filesystem::create_directories(output.parent_path());
sourcemeta::one::write_file(
sourcemeta::one::metapack_write_file(
output, app.positional().at(0), std::string{app.positional().at(1)},
app.contains("gzip") ? sourcemeta::one::Encoding::GZIP
: sourcemeta::one::Encoding::Identity,
sourcemeta::core::JSON{nullptr}, std::chrono::milliseconds::zero());
app.contains("gzip") ? sourcemeta::one::MetapackEncoding::GZIP
: sourcemeta::one::MetapackEncoding::Identity,
{}, std::chrono::milliseconds::zero());
return EXIT_SUCCESS;
} catch (const std::exception &error) {
std::cerr << "unexpected error: " << error.what() << "\n";
Expand Down
44 changes: 22 additions & 22 deletions src/build/delta.cc
Original file line number Diff line number Diff line change
Expand Up @@ -321,43 +321,42 @@ auto delta(const BuildPhase phase, const BuildPlan::Type build_type,
// the dependencies.metapack keys that reference it. This is a
// single O(keys) pass instead of O(affected × keys).
std::unordered_map<std::string, std::vector<std::string>>
reverse_dep_index;
for (const auto dep_key : entries.keys()) {
if (!dep_key.ends_with("/%/dependencies.metapack")) {
reverse_dependency_index;
for (const auto dependency_key : entries.keys()) {
if (!dependency_key.ends_with("/%/dependencies.metapack")) {
continue;
}

const auto *dep_entry{entries.entry(std::string{dep_key})};
if (dep_entry == nullptr) {
const auto *dependency_entry{
entries.entry(std::string{dependency_key})};
if (dependency_entry == nullptr) {
continue;
}

for (const auto &dependency : dep_entry->dependencies) {
const auto &dep_path{dependency.native()};
if (!dep_path.starts_with(schemas_prefix)) {
for (const auto &dependency : dependency_entry->dependencies) {
const auto &dependency_path{dependency.native()};
if (!dependency_path.starts_with(schemas_prefix)) {
continue;
}

const auto sentinel_pos{dep_path.find("/%/", owner_start)};
const auto sentinel_pos{dependency_path.find("/%/", owner_start)};
if (sentinel_pos == std::string::npos) {
continue;
}

auto referenced_schema{
dep_path.substr(owner_start, sentinel_pos - owner_start)};
dependency_path.substr(owner_start, sentinel_pos - owner_start)};
if (affected_schemas.contains(referenced_schema)) {
reverse_dep_index[std::move(referenced_schema)].emplace_back(
dep_key);
reverse_dependency_index[std::move(referenced_schema)].emplace_back(
dependency_key);
}
}
}

// Deduplicate: a single dep_key may reference the same schema
// through multiple dependency paths
for (auto &[schema, dep_keys] : reverse_dep_index) {
std::ranges::sort(dep_keys);
const auto [first, last] = std::ranges::unique(dep_keys);
dep_keys.erase(first, last);
for (auto &[schema, dependency_keys] : reverse_dependency_index) {
std::ranges::sort(dependency_keys);
const auto [first, last] = std::ranges::unique(dependency_keys);
dependency_keys.erase(first, last);
}

std::vector<BuildPlan::Action> dependents_wave;
Expand All @@ -373,11 +372,12 @@ auto delta(const BuildPhase phase, const BuildPlan::Type build_type,
append_filename(schema_base, "dependents.metapack")}};

BuildPlan::Action::Dependencies action_dependencies;
const auto reverse_iterator{reverse_dep_index.find(relative_string)};
if (reverse_iterator != reverse_dep_index.end()) {
const auto reverse_iterator{
reverse_dependency_index.find(relative_string)};
if (reverse_iterator != reverse_dependency_index.end()) {
action_dependencies.reserve(reverse_iterator->second.size());
for (const auto &dep_key : reverse_iterator->second) {
action_dependencies.emplace_back(dep_key);
for (const auto &dependency_key : reverse_iterator->second) {
action_dependencies.emplace_back(dependency_key);
}
}

Expand Down
1 change: 1 addition & 0 deletions src/index/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ endif()

target_link_libraries(sourcemeta_one_index PRIVATE sourcemeta::one::resolver)
target_link_libraries(sourcemeta_one_index PRIVATE sourcemeta::one::shared)
target_link_libraries(sourcemeta_one_index PRIVATE sourcemeta::one::metapack)
target_link_libraries(sourcemeta_one_index PRIVATE sourcemeta::one::configuration)
target_link_libraries(sourcemeta_one_index PRIVATE sourcemeta::one::web)

Expand Down
Loading
Loading