Skip to content

Better catch Blaze unsupported required vocabulary errors#782

Draft
jviotti wants to merge 2 commits intomainfrom
required-vocabulary-blaze
Draft

Better catch Blaze unsupported required vocabulary errors#782
jviotti wants to merge 2 commits intomainfrom
required-vocabulary-blaze

Conversation

@jviotti
Copy link
Member

@jviotti jviotti commented Mar 25, 2026

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

@augmentcode
Copy link

augmentcode bot commented Mar 25, 2026

🤖 Augment PR Summary

Summary: Improves how the CLI reports Blaze compilation failures caused by schemas requiring unsupported vocabularies.

Changes:

  • Pass the build-time Resolver into Blaze template generation so custom metaschemas/vocabularies can be resolved during analysis/compile.
  • Catch SchemaVocabularyError during plan execution and rethrow as FileError<SchemaVocabularyError> when a schema entry is known, attaching the originating file path.
  • Extend top-level error handling to print the offending vocabulary URI (and schema path when available).
  • Add a CLI regression test covering a custom metaschema that requires an unknown vocabulary.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Index (community)

Details
Benchmark suite Current: b688997 Previous: 1275841 Ratio
Add one schema (0 existing) 21 ms 21 ms 1
Add one schema (100 existing) 26 ms 28 ms 0.93
Add one schema (1000 existing) 87 ms 85 ms 1.02
Add one schema (10000 existing) 729 ms 809 ms 0.90
Update one schema (1 existing) 18 ms 19 ms 0.95
Update one schema (101 existing) 26 ms 26 ms 1
Update one schema (1001 existing) 90 ms 87 ms 1.03
Update one schema (10001 existing) 740 ms 743 ms 1.00
Cached rebuild (1 existing) 10 ms 10 ms 1
Cached rebuild (101 existing) 15 ms 13 ms 1.15
Cached rebuild (1001 existing) 37 ms 38 ms 0.97
Cached rebuild (10001 existing) 299 ms 297 ms 1.01
Index 100 schemas 118 ms 125 ms 0.94
Index 1000 schemas 986 ms 989 ms 1.00
Index 10000 schemas 14168 ms 14453 ms 0.98

This comment was automatically generated by workflow using github-action-benchmark.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Index (enterprise)

Details
Benchmark suite Current: b688997 Previous: 1275841 Ratio
Add one schema (0 existing) 22 ms 22 ms 1
Add one schema (100 existing) 28 ms 29 ms 0.97
Add one schema (1000 existing) 86 ms 85 ms 1.01
Add one schema (10000 existing) 839 ms 720 ms 1.17
Update one schema (1 existing) 22 ms 21 ms 1.05
Update one schema (101 existing) 27 ms 28 ms 0.96
Update one schema (1001 existing) 88 ms 85 ms 1.04
Update one schema (10001 existing) 727 ms 734 ms 0.99
Cached rebuild (1 existing) 13 ms 12 ms 1.08
Cached rebuild (101 existing) 14 ms 14 ms 1
Cached rebuild (1001 existing) 39 ms 38 ms 1.03
Cached rebuild (10001 existing) 304 ms 305 ms 1.00
Index 100 schemas 124 ms 124 ms 1
Index 1000 schemas 1024 ms 1094 ms 0.94
Index 10000 schemas 14077 ms 14706 ms 0.96

This comment was automatically generated by workflow using github-action-benchmark.

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@jviotti jviotti force-pushed the required-vocabulary-blaze branch 3 times, most recently from 49519f9 to d960e71 Compare March 25, 2026 20:56
@jviotti jviotti marked this pull request as draft March 25, 2026 21:01
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@jviotti jviotti force-pushed the required-vocabulary-blaze branch from d960e71 to 3feb772 Compare March 25, 2026 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant