Skip to content

Remove incorrect external tooltips for linter rules #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jviotti merged 1 commit into from
Mar 6, 2026
Merged

Remove incorrect external tooltips for linter rules #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion test/vscode/extension.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,11 +167,22 @@ suite('Extension Test Suite', () => {
const document = await openFixture('test-schema.json');
await vscode.commands.executeCommand('sourcemeta-studio.openPanel');
const diagnostics = await waitForDiagnostics(document.uri, LINT_SOURCE);
const ruleIds = diagnostics.map(d => d.code.value);
const ruleIds = diagnostics.map(d => d.code);
assert.ok(ruleIds.includes('top_level_description'));
assert.ok(ruleIds.includes('top_level_examples'));
});

test('Should not provide a URL target for lint diagnostic codes', async function() {
this.timeout(15000);
await activateExtension();
const document = await openFixture('test-schema.json');
await vscode.commands.executeCommand('sourcemeta-studio.openPanel');
const diagnostics = await waitForDiagnostics(document.uri, LINT_SOURCE);
for (const diagnostic of diagnostics) {
assert.strictEqual(typeof diagnostic.code, 'string');
}
});

test('Should include related information in lint diagnostics', async function() {
this.timeout(15000);
await activateExtension();
Expand Down
8 changes: 2 additions & 6 deletions vscode/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,12 +232,8 @@ function updateLintDiagnostics(documentUri, errors) {

diagnostic.source = 'Sourcemeta Studio (Lint)';

if (error.id) {
diagnostic.code = {
value: error.id,
target: vscode.Uri.parse(`https://github.com/Karan-Palan/json-schema-lint-rules/tree/main/docs/${error.id}.md`)
};
}
// TODO: Provide a documentation URL target when we have per-rule docs
diagnostic.code = error.id;

diagnostic.relatedInformation = buildRelatedInfo(
new vscode.Location(documentUri, range), [
Expand Down