Skip to content

Allow single Object fields to accept any type in acceptChange #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sovdeeth merged 2 commits into from
Aug 27, 2025
Merged

Allow single Object fields to accept any type in acceptChange #19

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
130de2d
allow single Object fields to accept any type in acceptChange
miberss Aug 24, 2025
7c1eea7
move Object check under the existing isAnyFieldSingle check
miberss Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/main/java/com/sovdee/oopsk/elements/expressions/ExprFieldAccess.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,11 @@ protected Object[] get(Event event, Struct[] source) {
// return all return types
return Arrays.stream(returnTypes).map(Class::arrayType).toArray(Class<?>[]::new);

// if a field is single and object, it should allow object stuff
if (isAnyFieldSingle && returnType == Object.class) {
return new Class<?>[]{Object.class};
}

Copy link
Owner

@sovdeeth sovdeeth Aug 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd move this under the existing isAnyFieldSingle check but otherwise seems fine

// if the mode is set, always allow changes
if (mode == ChangeMode.SET)
// return all return types
Expand Down