Json enum extensions - #818
Merged
Merged
Conversation
ArchangelWTF
approved these changes
Jul 22, 2026
ArchangelWTF
left a comment
Member
There was a problem hiding this comment.
LGTM, the migration docs on the wiki will need updating
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a two part PR that must be merged with the modules PR of the same name.
The goal of this PR is to provide an easier way to extend enums than having to write their own pre-patchers and understanding the pitfalls that come with using libs like Mono.Cecil or AsmResolver.
ClientEnumDefinitionsmanually by mod authors. This singleton only exists if the mod loader is enabled.