Fixed looped audio playback position calculation #6325
+67
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PJB3005
requested changes
Dec 4, 2025
Member
PJB3005
left a comment
PJB3005
left a comment
There was a problem hiding this comment.
Do not copy paste this code around everywhere
PJB3005
added
T: Bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered an odd bug: if I go far away from a looped audio source and return, the audio stops playing on the client. Disconnecting and reconnecting restores playback.
I figured out that it was a bug with the playback position calculation. It didn't account for the Loop parameter correctly and stopped playing because the position exceeded the audio length.
Here is a fix. + clean up redundant code and unused usings
Tests