Skip to content

Enable registration api#38

Open
Rinary1 wants to merge 5 commits into
space-wizards:masterfrom
Rinary1:enable-registration
Open

Enable registration api#38
Rinary1 wants to merge 5 commits into
space-wizards:masterfrom
Rinary1:enable-registration

Conversation

@Rinary1

@Rinary1 Rinary1 commented Jun 28, 2026

Copy link
Copy Markdown

Re-enables registration api with security fixes, summary:

  1. Added Email Validation for Registration and Confirmation.
  2. Added Password minimal and maximum length(from 6 to 100, same as on page)
  3. Added username minimal and maximum length(from 3 to 32, added to registration page)
  4. Added rate limits for registration and confirmation:
    • 2 per hour for confirmation.
    • 5 per 15 minutes for registration.
  5. Added security notice when user tries to register account on already registered email.
  6. Fixed issue when confirmation can be sent on already confirmed email.

Makes some "out of topic" changes so as not to undermine "general equality":

  1. Added Rate Limits for Reset Password and Authenticate.
  2. Removed commented out code(nitpick).
  3. Added Message in Bed Request in Authenticate(nitpick).
  4. Added Email Validation for Reset Password.
  5. Added dummy user check in Unauthorized path so that the response times are roughly the same.
    (The same approach as with the Security Notice; its purpose is simply to make the response times for successful and unsuccessful requests roughly the same, because before, unsuccessful response was faster)

Rinary1 added 5 commits June 28, 2026 23:57
This reverts commit 5c901d8bd6b9352546af336923fe78a8464cae8c.
@juliangiebel

Copy link
Copy Markdown
Contributor

We're not allowing API based user registration to prevent automated account creation. I also wouldn't send an email when someone tries to register with an email that and I wouldn't send an email when someone tries to register with an email that already exists.

Fixing the re-confirmation bug is, as well as the confirmation rate limit and the dummy account check.

@juliangiebel juliangiebel reopened this Jul 9, 2026

@juliangiebel juliangiebel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the registration api, the associated rate limit and the SendAccountExistsEmail email.
The rest looks fine. Sorry that you'll have to remove the bulk of your PR but registrations through the API aren't something we want to allow currently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants