Enable registration api#38
Open
Rinary1 wants to merge 5 commits into
Open
Conversation
This reverts commit 5c901d8bd6b9352546af336923fe78a8464cae8c.
Contributor
|
We're not allowing API based user registration to prevent automated account creation. I also wouldn't send an email when someone tries to register with an email that and I wouldn't send an email when someone tries to register with an email that already exists. Fixing the re-confirmation bug is, as well as the confirmation rate limit and the dummy account check. |
juliangiebel
requested changes
Jul 9, 2026
juliangiebel
left a comment
Contributor
There was a problem hiding this comment.
Remove the registration api, the associated rate limit and the SendAccountExistsEmail email.
The rest looks fine. Sorry that you'll have to remove the bulk of your PR but registrations through the API aren't something we want to allow currently
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-enables registration api with security fixes, summary:
Makes some "out of topic" changes so as not to undermine "general equality":
(The same approach as with the Security Notice; its purpose is simply to make the response times for successful and unsuccessful requests roughly the same, because before, unsuccessful response was faster)