Allow to parameterize seed value as in original murmur3 implementation#15
Merged
spaolacci merged 1 commit intospaolacci:masterfrom Aug 19, 2017
Merged
Allow to parameterize seed value as in original murmur3 implementation#15spaolacci merged 1 commit intospaolacci:masterfrom
spaolacci merged 1 commit intospaolacci:masterfrom
Conversation
Owner
|
Thanks for the PR. I had roughly equivalent stahed patch that I uploaded this morning in 4ec5a0f. The API is extended (not altered) with seed aware constructors and top-level accessors. It obiously conflicted your patch set, but I'd like to have at through since there's a few well deserved nitpicking, and I also find your seed slot location more ingenious than mine. I can cherry pick those extra changes manually, it's up to you. Thanks. |
809aab7 to
bbdbfec
Compare
Contributor
Author
|
Extending the API was probably the right move. I have rebased my PR based on your changes and preserved the stuff the I believe you wanted to keep. Lemme know what you think! |
Owner
|
All merged. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I was implementing this change, I missed that similar work has been done already (#9 and #10), but I figured it's worth sharing.
seedto every constructor (32-, 64- and 128-bit) as well asSum32,Sum64andSum128Obvious drawback is the API breakage of this lib, so maybe the way to go would be to tag the lib and start versioning (e.g.
0.1for current, and0.2for this PR and up)?