New Naming Scheme of Intermediates in MapFusionVertical #2302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbennun
requested changes
Feb 11, 2026
| # NOTE: For exclusive intermediate data there is no name collision, but | ||
| # for shared intermediate there _might_ be a name collision if the | ||
| # intermediate could be used in another MapFusionVertical operation. | ||
| new_inter_name: str = f"__map_fusion_reduced_data_of_{inter_name}" |
Collaborator
There was a problem hiding this comment.
The name is a bit lengthy in my opinion but ok
Collaborator
Author
There was a problem hiding this comment.
I agree, how about __map_fusion_{intern_name}?
I think we have to prefix it with __map_fusion so shorter than that you will not get.
tbennun
approved these changes
Feb 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MapFusionVerticalmust create new data (reduced versions of the intermediate data) and hence name it. Before it was using a naming scheme based on the node id, which might not be stable.The new scheme uses the name of the intermediate data and guarantees stable names for exclusive intermediate nodes and for shared intermediate nodes under the condition that they are only involved in one MapFusionVertical operation.