Query execution logs #282
Draft
Query execution logs #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves #42 This commit implements a new CLI command `benchmark logs` that allows users to query and retrieve full output and error logs for benchmark invocations across all supported platforms (AWS, Azure, GCP, Local, and OpenWhisk). Key features: - Query logs from experiment results JSON file (containing multiple invocations) - Query logs for a specific function and invocation ID - Support for custom time ranges to narrow log searches - Platform-specific implementations: - AWS: Uses CloudWatch Logs Insights API - Azure: Uses Application Insights Analytics - GCP: Uses Cloud Logging API - Local: Retrieves Docker container logs - OpenWhisk: Uses wsk CLI activation logs Usage examples: 1. Query logs from experiment results: ./sebs.py benchmark logs --config config.json --experiments-file experiments.json 2. Query logs for specific invocation: ./sebs.py benchmark logs --config config.json --function-name my-function --request-id abc123 Changes: - sebs/faas/system.py: Added abstract method get_invocation_logs() - sebs/aws/aws.py: Implemented AWS CloudWatch log retrieval - sebs/azure/azure.py: Implemented Azure Application Insights log retrieval - sebs/gcp/gcp.py: Implemented GCP Cloud Logging retrieval - sebs/local/local.py: Implemented Docker container log retrieval - sebs/openwhisk/openwhisk.py: Implemented OpenWhisk activation log retrieval - sebs.py: Added new 'benchmark logs' CLI command
Improvements to the logs CLI command: - Changed to use positional TARGET parameter instead of flags - Auto-detect if TARGET is a file path or function name - For experiments file: automatically use begin/end time from results - For function name: require --request-id flag - Added --minutes flag (default 30) to specify lookback window - Removed --start-time and --end-time flags (not needed) Usage examples: # Query logs from experiments file ./sebs.py benchmark logs experiments.json --config config.json # Query logs for specific function invocation ./sebs.py benchmark logs my-function --request-id abc123 --config config.json # Query with custom time window (60 minutes) ./sebs.py benchmark logs my-function --request-id abc123 --minutes 60 --config config.json Linting fixes: - Fixed line too long in sebs/aws/aws.py - Removed unused variable in sebs/azure/azure.py - Fixed mypy type error in sebs/gcp/gcp.py (timestamp variable name conflict) - Fixed potential None dereference in sebs/aws/aws.py - Applied Black code formatting to all modified files
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
mcopik
commented
Jan 17, 2026
| if logs: | ||
| for log_line in logs: | ||
| if log_line.strip(): # Skip empty lines | ||
| print(log_line) |
Collaborator
Author
There was a problem hiding this comment.
Use our logging, and aggregate logs according to invocation ID.
| sebs_client.logging.info(f"\n{'-' * 80}\nLogs:\n{'-' * 80}") | ||
| for log_line in logs: | ||
| if log_line.strip(): # Skip empty lines | ||
| print(log_line) |
|
|
||
| # Logs might not be available yet | ||
| retries += 1 | ||
| if retries < max_retries: |
Collaborator
Author
There was a problem hiding this comment.
Max retires should be a cli parameter
| container = c | ||
| break | ||
|
|
||
| # Retrieve logs |
Collaborator
Author
There was a problem hiding this comment.
Check our local execution actually provides logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to resolve issue #42. First attempt of doing end-to-end programming with Claude.