Add group number support in Taxon queries#4724
Conversation
emenslin
left a comment
There was a problem hiding this comment.
Testing instructions
Note: To properly test some of these, you will need to use Specify 6 locally to configure such a query or you can import this query that was created in Specify 6:
GroupNumber 6 Query.json
- Run a query that had the field "Group Number" added at the Family level in Specify 6
- Verify the output is consistent with Specify 6 and that all query functions work as expected
- Add "Group Number" to various ranks in the Taxon tree and ensure it can be searched on and results are displayed properly
- Verify that hiding and unhiding "Group Number" in the schema configuration make it appear as expected
There was a problem hiding this comment.
Testing instructions
- Run a query that had the field "Group Number" added at the Family level in Specify 6
- Verify the output is consistent with Specify 6 and that all query functions work as expected
- Add "Group Number" to various ranks in the Taxon tree and ensure it can be searched on and results are displayed properly
- Verify that hiding and unhiding "Group Number" in the schema configuration make it appear as expected
Everything looks to be working correctly, used it between a local specify 6 DB and used the query Grant posted for instructions on sdnhmherps as well.
And the query I made for the local DB (worked on sdnhmherps as well):
GroupNumberTest.json
Good work!
There was a problem hiding this comment.
- Run a query that had the field "Group Number" added at the Family level in Specify 6
- Verify the output is consistent with Specify 6 and that all query functions work as expected
- Add "Group Number" to various ranks in the Taxon tree and ensure it can be searched on and results are displayed properly
- Verify that hiding and unhiding "Group Number" in the schema configuration make it appear as expected
Query results are different between SP 6 and 7.

With one of the group number lines removed SP 7 matches.

And this is how it looks on v7 (without the GroupNumber lines)

There was a problem hiding this comment.
After further testing it looks like we were only able to reproduce the inconsistency between 6 and 7 if that specific query was made in 7 first, which wouldn't really affect users I don't think.
I don't have any notes on how I originally encountered the issue but it seems like that must've been how. So I think this is good.
Edit: Looks like its an issue with preferred Taxon #4973




Fixes #4723
This has been tested between both Specify 6 and 7. Existing queries that previously were non-functional created in 6 work now as well!
The previous configuration expected
<RankName> GroupNumber, but Specify 6 constructs the string ID for these query items as<RankName> groupNumber.Checklist
and self-explanatory (or properly documented)
Testing instructions
Note: To properly test some of these, you will need to use Specify 6 locally to configure such a query or you can import this query that was created in Specify 6:
GroupNumber 6 Query.json