Skip to content

Improve Preparation form links to Interactions#6110

Open
grantfitzsimmons wants to merge 29 commits intomainfrom
issue-6108
Open

Improve Preparation form links to Interactions#6110
grantfitzsimmons wants to merge 29 commits intomainfrom
issue-6108

Conversation

@grantfitzsimmons
Copy link
Member

@grantfitzsimmons grantfitzsimmons commented Jan 17, 2025

Fixes #6112

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add relevant documentation (Tester - Dev)

Before

You could not see any linked disposals or exchanges. Interactions that were empty still displayed with no results.

image

After

  • Interactions are only shown when they are linked to a Preparation
    • If none are linked, it shows "There are no interactions linked to this preparation"
  • When clicking on the "Show Interactions" button, the user should see all associated
    • Resolved Loans
    • Unresolved Loans
    • Gifts
    • Disposals
    • Exchange Out
    • Exchange In
Screen.Recording.2025-01-17.at.11.06.02.AM.mov

Testing instructions

You will need to make sure you have the "Show Interactions" / "Show Loans" button on the Preparation form to test this properly. If you do not already, here is the XML to add:

 <cell type="command" id="ShowLoansBtn" name="ShowLoansBtn" label="SHOW_INTERACTIONS" ignore="true"/>
  • Create a new CO with a memorable catalog number (you'll need it)
    No Interactions:
  • Create a new Preparation, give it a large count, and save
  • Click on the 'Show Interactions' button and see that "There are no interactions linked to this preparation." displays
    Gift:
  • Create a new Loan using the catalog number
  • Select some portion of your preparation's available count and create the loan
  • Go back to the Preparation and click on the 'Show Interactions' button– see it appears under "Open Loans"
  • Resolve the loan
  • Go back to the Preparation and click on the 'Show Interactions' button– see it appears under "Resolved Loans"
    Gift:
  • Create a new Gift using the catalog number
  • Select some portion of your preparation's available count and create the gift
  • Go back to the Gift and click on the 'Show Interactions' button– see it appears under "Gift"
    Exchange Out:
  • Create a new Exchange Out using the catalog number
  • Select some portion of your preparation's available count and create the Exchange Out
  • Go back to the Exchange Out and click on the 'Show Interactions' button– see it appears under "Exchange Out"
    Exchange In:
  • Create a new Exchange In using the catalog number
  • Select some portion of your preparation's available count and create the Exchange In
  • Go back to the Exchange In and click on the 'Show Interactions' button– see it appears under "Exchange In"
    Disposal:
  • Create a new Disposal using the catalog number
  • Select some portion of your preparation's available count and create the Disposal
  • Go back to the Disposal and click on the 'Show Interactions' button– see it appears under "Disposal"

Test this by using a combination of various interactions and preparations. Involve the preparation in multiple interactions of the same type. Verify that existing preparations linked to interactions appear as expected. Compare the behavior to production and let me know if this is undesirable.

  • OK I did it

If anyone is interested in updating the documentation for this, I would appreciate it. Thank you!

@grantfitzsimmons grantfitzsimmons marked this pull request as ready for review January 17, 2025 17:21
@grantfitzsimmons grantfitzsimmons marked this pull request as draft January 19, 2025 00:18
@grantfitzsimmons grantfitzsimmons marked this pull request as ready for review January 19, 2025 21:24
@melton-jason melton-jason self-requested a review January 19, 2025 21:31
'de-ch': 'Interaktionen',
},
noInteractions: {
comment: 'Example: There are no interactions linked to this {preparation}',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should explicit examples include a placeholder like this? Personally, I think examples should be one or more values the placeholder can take: there's hopefully less confusion for the localizer this way.

If you need to provide additional context for how this might be used or appear in the application, you can do so outside of the example; like in the following example:

comment: `
Example usage: "Choose collection:". Used only if there is nothing else on
this line after the colon heading
`,

@melton-jason
Copy link
Contributor

I've updated the branch, resolving merge conflicts and merged my changes from issue-6108-b (see #6110 (comment))!

Screen.Recording.2025-07-02.at.10.09.15.PM.mov

This is ready for testing as soon as the testing instructions are updated! 🚀

Triggered by aadcb21 on branch refs/heads/issue-6108
@grantfitzsimmons grantfitzsimmons modified the milestones: 7.x, 7.13.0 Feb 15, 2026
@grantfitzsimmons grantfitzsimmons requested review from a team and CarolineDenis and removed request for a team and CarolineDenis February 15, 2026 02:58
@grantfitzsimmons
Copy link
Member Author

grantfitzsimmons commented Feb 15, 2026

@melton-jason Even when I do git checkout e1a61345410416f65fe5c5d7832ad0d1c01c47e1, I don't see what you show in your video. Could you check it out (when we have time near 7.13)?

@CarolineDenis CarolineDenis modified the milestones: 7.13.0, 7.12.1 Feb 25, 2026
@grantfitzsimmons grantfitzsimmons requested a review from a team February 25, 2026 17:27
Copy link
Collaborator

@bhumikaguptaa bhumikaguptaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Create a new CO with a memorable catalog number (you'll need it)
    No Interactions:
  • Create a new Preparation, give it a large count, and save
  • Click on the 'Show Interactions' button and see that "There are no interactions linked to this preparation." displays
    Gift:
  • Create a new Loan using the catalog number
  • Select some portion of your preparation's available count and create the loan
  • Go back to the Preparation and click on the 'Show Interactions' button– see it appears under "Open Loans."
  • Resolve the loan
  • Go back to the Preparation and click on the 'Show Interactions' button– see it appears under "Resolved Loans."
Image

Every time I try to return a loan in the pop-up window instead of opening the form completely, the screen freezes.

Image

Secondly, the resolved loan records do not appear under "Resolved loans" as a separate category, they are just a part of the Loans overall.

Gift:

  • Create a new Gift using the catalog number
  • Select some portion of your preparation's available count and create the gift
  • Go back to the Gift and click on the 'Show Interactions' button– see it appears under "Gift"
    Exchange Out:
  • Create a new Exchange Out using the catalog number
  • Select some portion of your preparation's available count and create the Exchange Out
  • Go back to the Exchange Out and click on the 'Show Interactions' button– see it appears under "Exchange Out"
    Exchange In:
  • Create a new Exchange In using the catalog number
  • Select some portion of your preparation's available count and create the Exchange In
  • Go back to the Exchange In and click on the 'Show Interactions' button– see it appears under "Exchange In"
    Disposal:
  • Create a new Disposal using the catalog number
  • Select some portion of your preparation's available count and create the Disposal
  • Go back to the Disposal and click on the 'Show Interactions' button– see it appears under "Disposal"

Test this by using a combination of various interactions and preparations. Involve the preparation in multiple interactions of the same type. Verify that existing preparations linked to interactions appear as expected. Compare the behavior to production and let me know if this is undesirable.

  • OK I did it

Overall everything works except the loan features.
Link to DB: https://ojsmnh20250909-issue-6108.test.specifysystems.org/specify/view/collectionobject/454948/
Catalog number used in DB: 000005037

@github-project-automation github-project-automation bot moved this from 📋Back Log to Dev Attention Needed in General Tester Board Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Dev Attention Needed

Development

Successfully merging this pull request may close these issues.

Extend "Show Interactions" dialog to Disposal, Exchange In, and Exchange Out

5 participants