Improve Preparation form links to Interactions#6110
Improve Preparation form links to Interactions#6110grantfitzsimmons wants to merge 29 commits intomainfrom
Conversation
Triggered by 81067b5 on branch refs/heads/issue-6108
Triggered by 59802e1 on branch refs/heads/issue-6108
specifyweb/frontend/js_src/lib/components/FormCommands/index.tsx
Outdated
Show resolved
Hide resolved
specifyweb/frontend/js_src/lib/components/Interactions/PrepDialog.tsx
Outdated
Show resolved
Hide resolved
| 'de-ch': 'Interaktionen', | ||
| }, | ||
| noInteractions: { | ||
| comment: 'Example: There are no interactions linked to this {preparation}', |
There was a problem hiding this comment.
Should explicit examples include a placeholder like this? Personally, I think examples should be one or more values the placeholder can take: there's hopefully less confusion for the localizer this way.
If you need to provide additional context for how this might be used or appear in the application, you can do so outside of the example; like in the following example:
specify7/specifyweb/frontend/js_src/lib/localization/common.ts
Lines 639 to 642 in 36f7a7e
specifyweb/frontend/js_src/lib/components/FormCommands/ShowTransactions.tsx
Outdated
Show resolved
Hide resolved
specifyweb/frontend/js_src/lib/components/FormCommands/ShowTransactions.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Max Patiiuk <max@patii.uk>
|
I've updated the branch, resolving merge conflicts and merged my changes from Screen.Recording.2025-07-02.at.10.09.15.PM.movThis is ready for testing as soon as the testing instructions are updated! 🚀 |
Triggered by aadcb21 on branch refs/heads/issue-6108
|
@melton-jason Even when I do |
bhumikaguptaa
left a comment
There was a problem hiding this comment.
- Create a new CO with a memorable catalog number (you'll need it)
No Interactions: - Create a new Preparation, give it a large count, and save
- Click on the 'Show Interactions' button and see that "There are no interactions linked to this preparation." displays
Gift: - Create a new Loan using the catalog number
- Select some portion of your preparation's available count and create the loan
- Go back to the Preparation and click on the 'Show Interactions' button– see it appears under "Open Loans."
- Resolve the loan
- Go back to the Preparation and click on the 'Show Interactions' button– see it appears under "Resolved Loans."
Every time I try to return a loan in the pop-up window instead of opening the form completely, the screen freezes.
Secondly, the resolved loan records do not appear under "Resolved loans" as a separate category, they are just a part of the Loans overall.
Gift:
- Create a new Gift using the catalog number
- Select some portion of your preparation's available count and create the gift
- Go back to the Gift and click on the 'Show Interactions' button– see it appears under "Gift"
Exchange Out: - Create a new Exchange Out using the catalog number
- Select some portion of your preparation's available count and create the Exchange Out
- Go back to the Exchange Out and click on the 'Show Interactions' button– see it appears under "Exchange Out"
Exchange In: - Create a new Exchange In using the catalog number
- Select some portion of your preparation's available count and create the Exchange In
- Go back to the Exchange In and click on the 'Show Interactions' button– see it appears under "Exchange In"
Disposal: - Create a new Disposal using the catalog number
- Select some portion of your preparation's available count and create the Disposal
- Go back to the Disposal and click on the 'Show Interactions' button– see it appears under "Disposal"
Test this by using a combination of various interactions and preparations. Involve the preparation in multiple interactions of the same type. Verify that existing preparations linked to interactions appear as expected. Compare the behavior to production and let me know if this is undesirable.
- OK I did it
Overall everything works except the loan features.
Link to DB: https://ojsmnh20250909-issue-6108.test.specifysystems.org/specify/view/collectionobject/454948/
Catalog number used in DB: 000005037
Fixes #6112
Checklist
self-explanatory (or properly documented)
Before
You could not see any linked disposals or exchanges. Interactions that were empty still displayed with no results.
After
Screen.Recording.2025-01-17.at.11.06.02.AM.mov
Testing instructions
You will need to make sure you have the "Show Interactions" / "Show Loans" button on the Preparation form to test this properly. If you do not already, here is the XML to add:
No Interactions:
Gift:
Gift:
Exchange Out:
Exchange In:
Disposal:
Test this by using a combination of various interactions and preparations. Involve the preparation in multiple interactions of the same type. Verify that existing preparations linked to interactions appear as expected. Compare the behavior to production and let me know if this is undesirable.
If anyone is interested in updating the documentation for this, I would appreciate it. Thank you!