fix(querybuilder): Use correct formatting in QueryBuilder

[melton-jason]

Fixes #7510
See related #7080

The underlying problem was due to how the default formatter props for query execution were being interpreted and constructed, as well as the value of the format_expr being interpreted in

Specifically, the problem stemmed from the defined default values of ObjectFormatterProps:

specify7/specifyweb/backend/stored_queries/format.py

Lines 43 to 50 in b6a6a7b

	class ObjectFormatterProps(NamedTuple):
	format_agent_type: bool = False,
	format_picklist: bool = False,
	format_types: bool = True,
	numeric_catalog_number: bool = True,
	# format_expr determines if make_expr should call _fieldformat, like in versions before 7.10.2.
	# Batch edit expects it to be false to correctly handle some edge cases.
	format_expr: bool = False

Each of the values ending in a comma were being interpreted as one-tuples when it's clear they were meant to be booleans. For illustration, the above was being interpreted as the following:

 class ObjectFormatterProps(NamedTuple): 
     format_agent_type: bool = (False,)
     format_picklist: bool = (False, )
     format_types: bool = (True, )
     numeric_catalog_number: bool = (True, )
     # format_expr determines if make_expr should call _fieldformat, like in versions before 7.10.2. 
     # Batch edit expects it to be false to correctly handle some edge cases. 
     format_expr: bool = False 

This led to issues when the default was used in the execute function in stored_queries/execution.py:

specify7/specifyweb/backend/stored_queries/execution.py

Line 792 in b6a6a7b

formatter_props=ObjectFormatterProps(),

specify7/specifyweb/backend/stored_queries/execution.py

Line 808 in b6a6a7b

formatter_props=formatter_props,

Thus there were two issues with the default formatter_props:

• All non format_expr values in the ObjectFormatterProps was being interpreted incorrectly
• For normal Queries, the format_expr should by True. The default ObjectFormatterProps has a False format_expr

I think we should evaluate whether or not to change the default format_expr in ObjectFormatterProps to True, especially if the only case for it being False is batch edit.

Checklist

• Self-review the PR after opening it to make sure the changes look good and
  self-explanatory (or properly documented)
• Add relevant issue to release milestone
• Add pr to documentation list
• Add automated tests
• Add a reverse migration if a migration is present in the PR

Testing instructions

• Create a table format that includes a boolean field value (e.g. isPrimary or a yesNo field)
• See that the preview in the table format editor shows "Yes" or "No" where a value is present
• Run a query that returns that format
• See that the appropriate value is not displayed in v7.11.2.1
• See that the appropriate value is displayed in issue-7510

[emenslin]

• Create a table format that includes a boolean field value (e.g. isPrimary or a yesNo field)
• See that the preview in the table format editor shows "Yes" or "No" where a value is present
• Run a query that returns that format
• See that the appropriate value is not displayed in v7.11.2.1
• See that the appropriate value is displayed in issue-7510

Looks good, in query results a 1/0 is shown for a boolean field

I did notice though that if you try to batch edit with the format that includes the boolean field that it looks incorrect. It has the same behavior in main though so I am not sure if this is a problem for this PR or not so I will approve but I can rereview if this is something that needs to be fixed here or write up an issue if this is out of scope for this PR.

[grantfitzsimmons]

• Create a table format that includes a boolean field value (e.g. isPrimary or a yesNo field)
• See that the preview in the table format editor shows "Yes" or "No" where a value is present
• Run a query that returns that format
• See that the appropriate value is not displayed in v7.11.2.1
• See that the appropriate value is displayed in issue-7510

[alesan99]

• Create a table format that includes a boolean field value (e.g. isPrimary or a yesNo field)
• See that the preview in the table format editor shows "Yes" or "No" where a value is present
• Run a query that returns that format
• See that the appropriate value is not displayed in v7.11.2.1
• See that the appropriate value is displayed in issue-7510

---

before -> now

Formatters appear as expected now 👍

[grantfitzsimmons]

CSIRO confirmed this fix is good as well on Asana @melton-jason