Open
Conversation
CarolineDenis
approved these changes
Mar 6, 2026
grantfitzsimmons
approved these changes
Mar 7, 2026
Member
grantfitzsimmons
left a comment
There was a problem hiding this comment.
For dev testers, check the logs from the worker container to make sure no tree creation task is still running when the UI changes from the database loading page to the login page.
Open the configuration tool page.
Create a new discipline, preferably with a large tree.
I think we should consider telling the user once they start the creation of a discipline that it may take some time to finish after they click Save. Right now, it just drops them back to the form and they can't log in to any collections below. Not necessarily part of this PR.
- If refreshed frequently enough, you might see each collection added to the available login options individually as they each finish their own background tasks. If the collections finished quickly, you should at least see all the new collections as options to login as.
- When the page is refreshed, click "Change Collections", you should still see the recently finished collections, but not the one that was just created.
- Finally, try switching between the collections. See that there are no error messages, and no error message saying "discipline creation in progress"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7779
Implement a better solution for preventing users from logging into new collections that don't have all their celery background tasks completed. The initial solution we had was to check if any background tasks were running, and if so, don't allow new collections being used that were less than 15 minutes old to be safe. This new solution uses redis to match and track specific collection IDs to specific background tasks running on celery, so that we can verify exactly if a specific new collection has all of it's associated tasks completed, and thus can be safely used by the user.
Checklist
self-explanatory (or properly documented)
Testing instructions
Setup Tool
Config Tool Create Discipline/Collection