Skip to content

Fix importing trees with utf8 characters#7790

Merged
CarolineDenis merged 3 commits intomainfrom
issue-7778
Mar 6, 2026
Merged

Fix importing trees with utf8 characters#7790
CarolineDenis merged 3 commits intomainfrom
issue-7778

Conversation

@alesan99
Copy link
Contributor

@alesan99 alesan99 commented Mar 6, 2026

Fixes #7778

Databases with a latin1 character set will crash when importing trees with certain UTF-8 characters (Like the Minerals tree).
This PR prevents the crash, but the taxon names inside the Minerals tree still doesn't show up 100% correct simply because the database does not support it.

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add relevant issue to release milestone
  • Add pr to documentation list
  • Add automated tests
  • Add a reverse migration if a migration is present in the PR

Testing instructions

  • Go to the Taxon tree viewer
  • Import a new tree, choose Minerals
  • See that the tree imported correctly, without errors.
  • If you are using an existing database (not one created with the guided setup), no Taxon names should be garbled (like in the screenshot here -> New tree from Minerals default has incorrect encoding #7778)
  • Try to import other trees to make sure they still work.

@alesan99 alesan99 added this to the 7.12.0 milestone Mar 6, 2026
@alesan99 alesan99 marked this pull request as ready for review March 6, 2026 19:02
@alesan99 alesan99 requested review from a team March 6, 2026 19:36
@acwhite211 acwhite211 self-requested a review March 6, 2026 20:26
@CarolineDenis CarolineDenis merged commit fcf1968 into main Mar 6, 2026
14 checks passed
@CarolineDenis CarolineDenis deleted the issue-7778 branch March 6, 2026 22:00
@github-project-automation github-project-automation bot moved this from 📋Back Log to ✅Done in General Tester Board Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅Done

Development

Successfully merging this pull request may close these issues.

New tree from Minerals default has incorrect encoding

3 participants