Skip to content

Fix embedded record set multi-select#7796

Merged
acwhite211 merged 1 commit intomainfrom
issue-7793
Mar 10, 2026
Merged

Fix embedded record set multi-select#7796
acwhite211 merged 1 commit intomainfrom
issue-7793

Conversation

@acwhite211
Copy link
Member

@acwhite211 acwhite211 commented Mar 9, 2026

Fixes #7793

Handle undefined field for isToOne. This fixed the issue of the embedded record set multi-select not working correctly.

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add relevant issue to release milestone
  • Add pr to documentation list

Testing instructions

  • Create a new record set on any table.
  • Press the add button in the top left.
  • Select query builder.
  • Add any field.
  • Press Query.
  • Try to select multiple results .
  • See Select button is enabled and can be pressed.

Working on test-panel https://blankdbsetup2elizabeth20260302-issue-7793.test.specifysystems.org/specify/view/collectingevent/1/?recordsetid=7

@github-project-automation github-project-automation bot moved this to 📋Back Log in General Tester Board Mar 9, 2026
@acwhite211 acwhite211 added this to the 7.12.0 milestone Mar 9, 2026
@acwhite211 acwhite211 marked this pull request as ready for review March 9, 2026 20:08
@acwhite211 acwhite211 requested review from a team and emenslin March 9, 2026 20:10
Copy link
Collaborator

@bhumikaguptaa bhumikaguptaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • See Select button is enabled and can be pressed.
Image

It works as expected. I can add multiple records to the record set using select.

Copy link
Collaborator

@emenslin emenslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • See Select button is enabled and can be pressed.

Looks good!

@acwhite211 acwhite211 merged commit d36d874 into main Mar 10, 2026
14 checks passed
@acwhite211 acwhite211 deleted the issue-7793 branch March 10, 2026 16:27
@github-project-automation github-project-automation bot moved this from 📋Back Log to ✅Done in General Tester Board Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅Done

Development

Successfully merging this pull request may close these issues.

Cannot add multiple records to a record set through embedded query builder

4 participants